After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 725057 - System menu shows bluetooth, but I don't have any bluetooth devices
System menu shows bluetooth, but I don't have any bluetooth devices
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: system-status
3.11.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2014-02-24 11:57 UTC by Elad Alfassa
Modified: 2014-03-17 15:46 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
BluetoothMenu: fix visibility (1.54 KB, patch)
2014-03-17 15:36 UTC, Giovanni Campagna
committed Details | Review

Description Elad Alfassa 2014-02-24 11:57:06 UTC
The system menu shows a bluetooth submenu-thing. It has an option to "Turn Off" or "Bluetooth settings". I don't have any bluetooth device on this machine, and the Bluetooth panel in control-center doesn't show any devices either.

I think the shell shouldn't show this menu for machines without bluetooth, just like it doesn't show "mobile broadband" when you don't have a 3G modem.
Comment 1 Allan Day 2014-02-24 12:12:53 UTC
This is odd. It's not what I'd expect based on the discussion in bug 723848.
Comment 2 Allan Day 2014-02-24 12:14:08 UTC
Marking as NEEDINFO, since the cause isn't clear.
Comment 3 Giovanni Campagna 2014-02-24 12:16:23 UTC
Do you have a bluetooth rfkill device, for some weird reason?
(Try "rfkill list")

What do you get from
gdbus introspect --session --dest org.gnome.SettingsDaemon.Rfkill --object-path /org/gnome/SettingsDaemon/Rfkill --only-properties
?
Comment 4 Elad Alfassa 2014-02-24 12:18:23 UTC
0: phy0: Wireless LAN
	Soft blocked: no
	Hard blocked: no
[elad@weatherwax ~]$ gdbus introspect --session --dest org.gnome.SettingsDaemon.Rfkill --object-path /org/gnome/SettingsDaemon/Rfkill --only-properties 
node /org/gnome/SettingsDaemon/Rfkill {
  @org.freedesktop.DBus.GLib.CSymbol("gsd_rfkill_manager")
  interface org.gnome.SettingsDaemon.Rfkill {
    properties:
      readwrite b AirplaneMode = false;
      readonly b HardwareAirplaneMode = false;
      readonly b HasAirplaneMode = true;
      readwrite b BluetoothAirplaneMode = false;
      readonly b BluetoothHardwareAirplaneMode = false;
      readonly b BluetoothHasAirplaneMode = false;
  };
};
Comment 5 Giovanni Campagna 2014-02-24 12:24:18 UTC
Ok, gnome-shell looks at "BluetoothAirplaneMode" to see if bluetooth is enabled and should be shown, so g-s-d should set it to true if no bluetooth adapter is present.

Reassigning.
Comment 6 Bastien Nocera 2014-03-17 13:46:15 UTC
(In reply to comment #5)
> Ok, gnome-shell looks at "BluetoothAirplaneMode" to see if bluetooth is enabled
> and should be shown, so g-s-d should set it to true if no bluetooth adapter is
> present.
> 
> Reassigning.

      readonly b BluetoothHasAirplaneMode = false;

Huh. Parsing error?
Comment 7 Giovanni Campagna 2014-03-17 15:13:51 UTC
(In reply to comment #6)
> (In reply to comment #5)
> > Ok, gnome-shell looks at "BluetoothAirplaneMode" to see if bluetooth is enabled
> > and should be shown, so g-s-d should set it to true if no bluetooth adapter is
> > present.
> > 
> > Reassigning.
> 
>       readonly b BluetoothHasAirplaneMode = false;
> 
> Huh. Parsing error?

Oh! There is no BluetoothHasAirplaneMode in the client side interface in gnome-shell.

Ok, we can fix it here :)
Comment 8 Giovanni Campagna 2014-03-17 15:36:48 UTC
Created attachment 272175 [details] [review]
BluetoothMenu: fix visibility

In addition to BluetoothAirplaneMode, we need to check also
BluetoothHasAirplaneMode, which is indicative of bluetooth rfkill
devices (and by extension bluetooth adapters).
This prevents showing the menu if there is no adapter present.
Comment 9 Florian Müllner 2014-03-17 15:38:22 UTC
Review of attachment 272175 [details] [review]:

LGTM
Comment 10 Giovanni Campagna 2014-03-17 15:46:31 UTC
Attachment 272175 [details] pushed as c22264a - BluetoothMenu: fix visibility