After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 725055 - t/GdkPixbufLoader.t fails test 'got some area-updated signals' with recent gdk-pixbuf
t/GdkPixbufLoader.t fails test 'got some area-updated signals' with recent gd...
Status: RESOLVED FIXED
Product: gnome-perl
Classification: Bindings
Component: Gtk2
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gtk2-perl-bugs
gtk2-perl-bugs
Depends on:
Blocks:
 
 
Reported: 2014-02-24 11:24 UTC by intrigeri
Modified: 2014-03-24 19:36 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
t/GdkPixbufLoader.t: Use a bigger file to test chunking (975 bytes, patch)
2014-03-24 12:01 UTC, Colin Watson
committed Details | Review

Description intrigeri 2014-02-24 11:24:12 UTC
On current Debian unstable, t/GdkPixbufLoader.t fails test 'got some area-updated signals', as reported on https://bugs.debian.org/739809.

It does not fail (yet) on current Debian testing. Both distributions have the same version of libgtk2, but testing has gdk-pixbuf 2.28.2, while unstable has 2.30.5. I suspect the gdk-pixbuf update is the cause of the issue.
Comment 1 intrigeri 2014-03-22 10:55:30 UTC
FTR, I can still reproduce this on current Debian unstable. Any information I could provide to help fix this?
Comment 2 Colin Watson 2014-03-24 11:51:32 UTC
I bisected this to this gdk-pixbuf change:

commit 0352f8589831a7f76f3c66db643c4bf920422110
Author: Matthias Clasen <mclasen@redhat.com>
Date:   Tue Dec 17 08:51:09 2013 -0500

    Unify sniff buffer size

    GdkPixbufLoader was using 1k as a buffer size for sniffing file types,
    and the gdk_pixbuf_new_from_file() family of functions was using 4k,
    for no good reason. Unify this so we use the same buffer size
    everywhere.

:040000 040000 2060af0428f68667cbe9a90db8f173479149c9a7 eec9ecaf91ef4305dcb48a3486b395e5d5257053 M      gdk-pixbuf
Comment 3 Colin Watson 2014-03-24 12:01:24 UTC
OK, so the problem now is that gtk-demo/gnome-foot.png is less than the new buffer size, so the loader doesn't trigger any signals until forced to by closing the file.  We can work around this by simply using a bigger test file.  Patch attached.
Comment 4 Colin Watson 2014-03-24 12:01:50 UTC
Created attachment 272765 [details] [review]
t/GdkPixbufLoader.t: Use a bigger file to test chunking
Comment 5 Torsten Schoenfeld 2014-03-24 19:36:01 UTC
Thanks a lot for tracking this down.  Patch committed.