After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 724877 - GI libtool hack is not compatible with W32 CPython
GI libtool hack is not compatible with W32 CPython
Status: RESOLVED FIXED
Product: gobject-introspection
Classification: Platform
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gobject-introspection Maintainer(s)
gobject-introspection Maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2014-02-21 12:44 UTC by LRN
Modified: 2015-02-07 16:53 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Extend the hack towards backslashes as path separators (985 bytes, patch)
2014-02-21 12:44 UTC, LRN 		committed Details | Review

Description LRN 2014-02-21 12:44:44 UTC 
GI is libtool-aware and will replace ".libs/.libs" with ".libs".
This hack should be extended to support DOS-style ".libs\\.libs".
Comment 1 LRN 2014-02-21 12:44:49 UTC 
Created attachment 269905 [details] [review]
Extend the hack towards backslashes as path separators
Comment 2 Colin Walters 2014-02-21 12:49:30 UTC 
Review of attachment 269905 [details] [review]:

Looks OK.  Would have been nice to maybe use a regexp instead of a double replace, but this is fine.
Comment 3 Colin Walters 2014-02-21 12:50:31 UTC 
Or can we use os.sep here?  Something like:

libname = libname.replace('.libs' + os.sep + '.libs', '.libs')

?  Does that work for you?
Comment 4 LRN 2014-02-21 13:31:34 UTC 
M-m-m-m...i'd rather keep using both separators, unless it's possible to prove that libname is guaranteed to always contain os.sep. If libname contents are partially influenced by some outside things, it might end up with '/' separator even on W32.
Comment 5 Colin Walters 2014-02-22 23:17:28 UTC 
Ok, that's fine.

Attachment 269905 [details] pushed as 7987124 - Extend the hack towards backslashes as path separators
Comment 6 André Klapper 2015-02-07 16:53:26 UTC 
[Mass-moving gobject-introspection tickets to its own Bugzilla product - see bug 708029. Mass-filter your bugmail for this message: introspection20150207 ]