Created attachment 269897 [details] [review]
pls: Fix redefinition of compiler args

Created attachment 269898 [details] [review]
core: Fix API documentation typo

../../src/data/grl-data.c:389: warning: Parameter description
for grl_data_get_boolean::key is missing in source code comment block.

Attachment 269897 [details] pushed as 5f88b53 - pls: Fix redefinition of compiler args
Attachment 269898 [details] pushed as bd2a387 - core: Fix API documentation typo

What's the error here?

Did you see the rationale in my commit https://git.gnome.org/browse/grilo/commit/?id=3f66bb29a2d0f81479a435c1fabc80c08c4961be

Not having this means the build won't work unless an *old version* of grilo happens to be installed in the root.

I'm going to tag grilo in Continuous for now:
https://git.gnome.org/browse/gnome-continuous/commit/?id=603fdf1459f9ebad548bbc30c41405827cbfc11c

You should likely be able to reproduce the problem with:

jhbuild uninstall grilo
apt-get/yum remove grilo-devel
jhbuild buildone grilo

(In reply to comment #4)
> What's the error here?

Your patch does:
+INTROSPECTION_COMPILER_ARGS = --includedir=$(top_builddir)/src

Which is already done line 49:
https://git.gnome.org/browse/grilo/tree/libs/pls/Makefile.am#n49

With:
INTROSPECTION_COMPILER_ARGS = --includedir=$(top_srcdir)/src

What does remove the duplicate definition break exactly?

Right, I see the problem now. Both commits are broken...

Created attachment 270058 [details] [review]
pls: Fix build with grilo never installed

This re-applies the fix from:
https://git.gnome.org/browse/grilo/commit/?id=3f66bb29a2d0f81479a435c1fabc80c08c4961be

Which got broken by the wrong de-duplicating done in
5f88b535800d1105439641795ddd2e07fd113744

Review of attachment 270058 [details] [review]:

Ah, I see.  Thanks for investigating this.  Please also feel free to revert the tag commit to gnome-continuous after you push this.

Attachment 270058 [details] pushed as 790f350 - pls: Fix build with grilo never installed