After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 724830 - Runs in an unnecessarily small window on an 8" tablet
Runs in an unnecessarily small window on an 8" tablet
Status: RESOLVED FIXED
Product: gnome-mahjongg
Classification: Applications
Component: general
3.11.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-mahjongg-maint
gnome-mahjongg-maint
Depends on:
Blocks:
 
 
Reported: 2014-02-20 20:47 UTC by Adam Williamson
Modified: 2014-03-13 02:13 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Photo with a finger for scale (435.56 KB, image/jpeg)
2014-02-20 20:47 UTC, Adam Williamson
  Details
Increase the default window size to 900x600 (1.20 KB, patch)
2014-03-13 02:13 UTC, Michael Catanzaro
committed Details | Review

Description Adam Williamson 2014-02-20 20:47:27 UTC
Created attachment 269837 [details]
Photo with a finger for scale

Testing games on an 8", 800x1280 tablet at the request of Thomas Andersen.

On said tablet, gnome-mahjongg works pretty well, but it runs in a fairly small window, and I can't really see a reason it needs to. This makes all the tiles pretty finicky to interact with using a finger. You can play it, but it's more work than it needs to be.

The window looks like it's about 500x400 pixels or so.

Photo with a finger and terminal window for context will be attached.
Comment 1 Michael Catanzaro 2014-02-21 00:50:50 UTC
How bad does it look if you maximize the window?  Is it even possible to maximize?

I think it's reasonable to increase the window size to make it more useful on touchscreens, since the default theme is scalable.  An 800x600 window is just big enough that touching would probably work well if my laptop had a touchscreen.  Does that size seem reasonable on the fedlet? You can browse to org.gnome.gnome-mahjongg in dconf-editor to get the size exactly right. (Bigger than that starts to look... pretty big.)
Comment 2 Adam Williamson 2014-02-21 01:29:38 UTC
Maximized portrait looks pretty nice. Maximized landscape looks great!

Setting it to '800x600' and launching in portrait makes it not really quite 800 pixels wide (it doesn't cover the whole width of the screen) - I guess mutter wants some padding or something. It looks like it's about 750xsomething. Better than the current state, still slightly poky.
Comment 3 Michael Catanzaro 2014-02-21 02:38:52 UTC
Is it big enough to accurately select tiles?
Comment 4 Adam Williamson 2014-02-21 02:52:27 UTC
Just about, yeah. It feels nicer full-screen, though.
Comment 5 Michael Catanzaro 2014-02-21 15:16:35 UTC
If you set it to 900x600, does it maximize by default?
Comment 6 Michael Catanzaro 2014-02-24 22:15:26 UTC
Mario, does 900x600 seem an OK default to you?  This is exactly 50% larger than the current default size.  We could try some smaller ones too; I just think we need to make sure this is big enough so that touching works well by default.

(It's impossible to select a default window size that looks good on every monitor or device. Maximizing by default doesn't make sense because it will look anywhere from Bad to Really Bad depending if you have a Big to Really Big monitor, so I think it's best to just pick a size and trust to mutter to start it maximized if the screen is too small.)
Comment 7 Mario Wenzel 2014-02-25 09:20:32 UTC
I think as long as we are not provided with means to find out about high dpi devices we are stuck making guesses that are sure to not work on lots of devices. 900x600 seems just as good as any :)
Comment 8 Michael Catanzaro 2014-03-13 02:13:50 UTC
The following fix has been pushed:
0792aac Increase the default window size to 900x600
Comment 9 Michael Catanzaro 2014-03-13 02:13:53 UTC
Created attachment 271671 [details] [review]
Increase the default window size to 900x600

This will make the game playable on touchscreens without needing to
resize the window. The default theme is scalable, so why not make the
tiles big enough to touch?