After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 724793 - upnp: Prevent crash with some UPnP servers
upnp: Prevent crash with some UPnP servers
Status: RESOLVED FIXED
Product: grilo
Classification: Other
Component: plugins
unspecified
Other All
: Normal normal
: ---
Assigned To: grilo-maint
grilo-maint
: 725021 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2014-02-20 11:44 UTC by Bastien Nocera
Modified: 2014-02-24 00:30 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
upnp: Prevent crash with some UPnP servers (1.77 KB, patch)
2014-02-20 11:44 UTC, Bastien Nocera 		committed Details | Review

Description Bastien Nocera 2014-02-20 11:44:01 UTC 
.
Comment 1 Bastien Nocera 2014-02-20 11:44:04 UTC 
Created attachment 269794 [details] [review]
upnp: Prevent crash with some UPnP servers

The "Skifta" iOS UPnP server seems to pass us " " as a list
of changed items. We need to protect better against bad input and
avoid accessing data beyond the array.
Comment 2 Juan A. Suarez Romero 2014-02-20 22:06:38 UTC 
commit 61fce31b9dc9fc6b246f0cb533f62877ad509ed8
Author: Bastien Nocera <hadess@hadess.net>
Date:   Thu Feb 20 12:42:02 2014 +0100

    upnp: Prevent crash with some UPnP servers
    
    The "Skifta" iOS UPnP server seems to pass us " " as a list
    of changed items. We need to protect better against bad input and
    avoid accessing data beyond the array.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=724793

 src/upnp/grl-upnp.c | 23 ++++++++++++++++-------
 1 file changed, 16 insertions(+), 7 deletions(-)
Comment 3 Bastien Nocera 2014-02-24 00:30:53 UTC 
*** Bug 725021 has been marked as a duplicate of this bug. ***