After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 724763 - Failure to read underlines from localc-generated file
Failure to read underlines from localc-generated file
Status: RESOLVED FIXED
Product: Gnumeric
Classification: Applications
Component: import/export OOo / OASIS
git master
Other All
: Normal normal
: ---
Assigned To: Andreas J. Guelzow
Jody Goldberg
Depends on:
Blocks:
 
 
Reported: 2014-02-20 01:55 UTC by Morten Welinder
Modified: 2014-02-20 05:21 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
The generated sy2.ods file (21.42 KB, application/vnd.oasis.opendocument.spreadsheet)
2014-02-20 01:55 UTC, Morten Welinder
Details

Description Morten Welinder 2014-02-20 01:55:02 UTC
1: ../src/ssconvert ../samples/style-tests.gnumeric sy.ods
2: localc sy.ods
3: save as sy2.ods

Potential problem: right justify has been dropped.  This could be our
problem on the write side or LO's problem on the read side.

Problem: when we read sy2.ods, we see no underlines.  LO does see them.
Comment 1 Morten Welinder 2014-02-20 01:55:47 UTC
Created attachment 269745 [details]
The generated sy2.ods file
Comment 2 Andreas J. Guelzow 2014-02-20 04:27:09 UTC
underlines are a mess in ODF. They are specified via two distinct attributes and the interaction is not clearly specified. There exists an interoperability recommendation of the OASIS OIC TC, but nobody seems to follow that one.
Comment 3 Andreas J. Guelzow 2014-02-20 04:28:40 UTC
In this specific file we have:

<style:text-properties fo:color="#000000" style:text-line-through-style="none" style:text-position="" style:font-name="Sans" fo:font-size="10pt" fo:font-style="normal" style:text-underline-style="solid" style:text-underline-width="auto" style:text-underline-color="font-color" fo:font-weight="normal"/>
Comment 4 Andreas J. Guelzow 2014-02-20 04:35:18 UTC
So style:text-underline-style="solid" but style:text-underline-type is not set. We are currently defaulting to style:text-underline-type="none", which does not seem to work here.
Comment 5 Andreas J. Guelzow 2014-02-20 04:47:38 UTC
Apparently I am looking at the wrong stuff: underlines work fine if they are attached to the text, but the underline in the file is attached to the table cell.
Comment 6 Andreas J. Guelzow 2014-02-20 05:13:17 UTC
The underlining should be fixed.
Comment 7 Andreas J. Guelzow 2014-02-20 05:21:20 UTC
Regarding 'right justify', we are creating the style:
    
<style:style style:name="ACE-0x226d7c8" style:family="table-cell" style:data-style-name="General">
      <style:table-cell-properties fo:background-color="transparent" fo:border-top="0.000cm none #c7c7c7" fo:border-bottom="0.000cm none #c7c7c7" fo:border-left="0.000cm none #c7c7c7" fo:border-right="0.000cm none #c7c7c7" style:diagonal-bl-tr="0.000cm none #c7c7c7" style:diagonal-tl-br="0.000cm none #c7c7c7" style:vertical-align="bottom" fo:wrap-option="no-wrap" style:shrink-to-fit="false" style:writing-mode="page" style:glyph-orientation-vertical="auto" style:cell-protect="protected" style:rotation-align="none" style:rotation-angle="0" style:print-content="true" style:decimal-places="13" style:text-align-source="fix" style:repeat-content="false"/>
      <style:paragraph-properties style:writing-mode-automatic="true" fo:text-align="right" fo:text-indent="0.00pt"/>
      <style:text-properties text:display="true" fo:font-weight="normal" fo:font-style="normal" style:text-line-through-type="none" style:text-line-through-style="none" style:text-underline-type="none" style:text-underline-style="none" style:text-underline-width="auto" style:text-position="0% 100%" fo:font-size="10.00pt" fo:color="#000000" fo:font-family="Sans"/>
    </style:style>

The interesting part is:
<style:paragraph-properties style:writing-mode-automatic="true" fo:text-align="right" fo:text-indent="0.00pt"/>

In ODF 1.2 we have
-------------------------------
The fo:text-align attribute when used with the <style:paragraph-properties>
element specifies the alignment of paragraphs in a text.
The values of start and end are interpreted according to the writing direction of the text.
The fo:text-align attribute is usable with the following element: <style:paragraph-
properties> 17.6.
The values of the fo:text-align attribute are start, end, left, right, center or
justify.
-------------------------------

So I would think that this is a LO problem.
Comment 8 Andreas J. Guelzow 2014-02-20 05:21:32 UTC
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.