After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 724693 - Restore padding in GtkActionBar
Restore padding in GtkActionBar
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: Other
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2014-02-18 22:17 UTC by Paolo Borelli
Modified: 2014-02-19 03:57 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch (1.66 KB, patch)
2014-02-18 22:17 UTC, Paolo Borelli
none Details | Review

Description Paolo Borelli 2014-02-18 22:17:30 UTC
Padding got lost when porting to GtkBox center widget because GtkBox does not support css padding.

As discussed on IRC, adding that support now is too risky, so wrap it in a GtkFrame that instead support padding etc. The padding defined in Adwaita now works as expected.


Unrelated to the patch: I do not see any code in gtkactionbar.c that deals with these widgets as "internal children"... I fear that gtk_container_get_children will return the revealer instead of the user widgets.
Comment 1 Paolo Borelli 2014-02-18 22:17:54 UTC
Created attachment 269628 [details] [review]
patch