After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 724669 - Standalone package install UX review
Standalone package install UX review
Status: RESOLVED FIXED
Product: gnome-software
Classification: Applications
Component: General
3.11.x
Other Linux
: Normal normal
: ---
Assigned To: GNOME Software maintainer(s)
GNOME Software maintainer(s)
3.12 ux
Depends on:
Blocks:
 
 
Reported: 2014-02-18 17:08 UTC by Allan Day
Modified: 2014-03-03 09:40 UTC
See Also:
GNOME target: ---
GNOME version: 3.11/3.12


Attachments
PackageKit: make use of the summary in details, when available (2.08 KB, patch)
2014-02-24 17:46 UTC, Giovanni Campagna
committed Details | Review
details: Remove the "Getting software details…" label (1.55 KB, patch)
2014-02-24 23:21 UTC, Kalev Lember
committed Details | Review
details: Fade in the loading spinner (1.18 KB, patch)
2014-02-24 23:21 UTC, Kalev Lember
committed Details | Review
details: Use application/x-executable icon for local packages (1.03 KB, patch)
2014-02-24 23:21 UTC, Kalev Lember
committed Details | Review
details: Add CSS for infobar theming (4.14 KB, patch)
2014-02-24 23:21 UTC, Kalev Lember
committed Details | Review
details: Show the filename for local package installation (2.68 KB, patch)
2014-02-24 23:21 UTC, Kalev Lember
committed Details | Review
details: Align package details as per latest mockups (11.06 KB, patch)
2014-02-24 23:21 UTC, Kalev Lember
committed Details | Review
details: Let the 'origin' span 3 columns (1.58 KB, patch)
2014-02-24 23:21 UTC, Kalev Lember
committed Details | Review
details: Remove spacing between infobar labels (2.24 KB, patch)
2014-02-24 23:21 UTC, Kalev Lember
committed Details | Review
details: Don't show missing history on a local package install (989 bytes, patch)
2014-02-24 23:21 UTC, Kalev Lember
committed Details | Review
details: Remove duplicate copy-pasted code (1.12 KB, patch)
2014-02-24 23:21 UTC, Kalev Lember
committed Details | Review
details: Update software source message wording (5.24 KB, patch)
2014-02-24 23:21 UTC, Kalev Lember
reviewed Details | Review
repositories (287.08 KB, patch)
2014-02-25 18:52 UTC, Jakub Steiner
committed Details | Review

Description Allan Day 2014-02-18 17:08:50 UTC
Various issues from testing standalone package install today:

 * When software is opening a package, you get a more or less blank window with a spinner and a "Getting software details..." string. The string is a bit misleading, since it sounds like it is downloading information from the web.

  - Remove the "Getting software details..." string (and leave the spinner).
  - Show a back button to allow the action to be cancelled without closing the app.
  - Show a heading in the header bar? "Loading"?

 * Packages always use the symbolic package icon, which doesn't feel the best and is inconsistent with our symbolic icon use elsewhere in Software.

 - Add-ons - use system-run-symbolic
 - Apps - use emblem-system-symbolic
 - Repos - no icon?

 * Software doesn't indicate if the package is already installed. I would treat this in the same way as one of the other info boxes - hide the install button and have the box say "This software is already installed".

 * The information boxes look rather bright and jump out from the page. It would be nicer to use the colours in the mockups.

 * The line spacing in the information boxes looks off - it looks like the lines are trying to get away from each other. They should be more tightly grouped in the centre of the box.

 * The details section is missing a reference to the package file. It would be useful to include the file name here.

 * I'm unhappy with a couple of the headings in the info boxes (my bad). They sound like robot speak.

 - Replace "Software Source Identified" with "<software name> Contains a Software  Source"

 - Replace "No Update Source Detected" with "<software name> Does Not Contain a Source Source"
Comment 1 Jakub Steiner 2014-02-18 17:38:17 UTC
Some further discussion happened on IRC and we agreed on sticking with fullcolor style for these icons. generic application/x-executable will be used for apps if we really cannot figure out how to look up the actual app icon.

I will try coming up with something for repos and create a puzzle piece for addons and ship these with gnome-icon-theme.
Comment 2 Jakub Steiner 2014-02-21 16:24:58 UTC
gnome-icon-theme gained one of the icons, application-x-addon. Package repository still on the to do.
Comment 3 Giovanni Campagna 2014-02-24 17:46:02 UTC
Created attachment 270162 [details] [review]
PackageKit: make use of the summary in details, when available

If PackageKit is recent enough, use the summary from GetDetails
as the application summary for normal apps, and use it as the
application name for local filenames (in place of the ugly
package name).

Another issue in the standalone package flow is when no appstream
metadata is available at all, and we show the ugly package name
as the application name. This patch solves it.
Comment 4 Kalev Lember 2014-02-24 23:21:03 UTC
Created attachment 270202 [details] [review]
details: Remove the "Getting software details…" label

Only show a spinner while loading, and remove the text.
Comment 5 Kalev Lember 2014-02-24 23:21:07 UTC
Created attachment 270203 [details] [review]
details: Fade in the loading spinner

Fade in the spinner during 1000 ms. Since most PK backends are now
sufficiently fast to load the package details in a fraction of second,
this avoids needlessly flickering the spinner.
Comment 6 Kalev Lember 2014-02-24 23:21:11 UTC
Created attachment 270204 [details] [review]
details: Use application/x-executable icon for local packages
Comment 7 Kalev Lember 2014-02-24 23:21:15 UTC
Created attachment 270205 [details] [review]
details: Add CSS for infobar theming

... as per latest mockups.
Comment 8 Kalev Lember 2014-02-24 23:21:19 UTC
Created attachment 270206 [details] [review]
details: Show the filename for local package installation
Comment 9 Kalev Lember 2014-02-24 23:21:23 UTC
Created attachment 270207 [details] [review]
details: Align package details as per latest mockups

This makes the details section wider and aligns the two columns of
information as per latest mockups. The width of the columns and the
headings is now controlled by two size groups.
Comment 10 Kalev Lember 2014-02-24 23:21:27 UTC
Created attachment 270208 [details] [review]
details: Let the 'origin' span 3 columns

This can be a really long text and doesn't look good when ellipsized:
could be e.g. "Fedora - Rawhide - Developmental packages for the next
Fedora release" or a particularly long local package name.
Comment 11 Kalev Lember 2014-02-24 23:21:31 UTC
Created attachment 270209 [details] [review]
details: Remove spacing between infobar labels
Comment 12 Kalev Lember 2014-02-24 23:21:35 UTC
Created attachment 270210 [details] [review]
details: Don't show missing history on a local package install
Comment 13 Kalev Lember 2014-02-24 23:21:39 UTC
Created attachment 270211 [details] [review]
details: Remove duplicate copy-pasted code
Comment 14 Kalev Lember 2014-02-24 23:21:43 UTC
Created attachment 270212 [details] [review]
details: Update software source message wording

... as suggested in the ticket.
Comment 15 Kalev Lember 2014-02-24 23:38:08 UTC
(In reply to comment #0)
>  * I'm unhappy with a couple of the headings in the info boxes (my bad). They
> sound like robot speak.
> 
>  - Replace "Software Source Identified" with "<software name> Contains a
> Software  Source"
> 
>  - Replace "No Update Source Detected" with "<software name> Does Not Contain a
> Source Source"

These strings might need some more tinkering. One thing that can mess it up is that we have no control what <software name> is: it could read 'firefox' or 'The Best Web Browser' or 'a browser' -- and depending on how the words are capitalized, it can mess up the text.

In any case, I have some before and after screenshots:

firefox-27.0-1.fc21.x86_64.rpm:
https://people.gnome.org/~klember/gnome-software-local-install-firefox1.png
https://people.gnome.org/~klember/gnome-software-local-install-firefox2.png

rpmfusion-free-release-rawhide.noarch.rpm:
https://people.gnome.org/~klember/gnome-software-local-install-rpmfusion1.png
https://people.gnome.org/~klember/gnome-software-local-install-rpmfusion2.png
Comment 16 Allan Day 2014-02-25 09:38:22 UTC
(In reply to comment #15)
...
> >  - Replace "Software Source Identified" with "<software name> Contains a
> > Software  Source"
> > 
> >  - Replace "No Update Source Detected" with "<software name> Does Not Contain a
> > Source Source"
> 
> These strings might need some more tinkering. One thing that can mess it up is
> that we have no control what <software name> is: it could read 'firefox' or
> 'The Best Web Browser' or 'a browser' -- and depending on how the words are
> capitalized, it can mess up the text.

Hmm, OK. Maybe we shouldn't use the name of the software itself then. "Software Source Included" and "No Software Source Included"? (I'm open to suggestions!)

> In any case, I have some before and after screenshots:

These look fantastic; I'm impressed.

The only issue I can see is the use of icons. We want to use the full colour system-software-install for repositories and the new application-x-addon for add ons.
Comment 17 Allan Day 2014-02-25 09:50:20 UTC
Oh, one other thing: don't show the updated or category fields if they are going to read 'never' or 'none'?
Comment 18 Richard Hughes 2014-02-25 10:58:42 UTC
Review of attachment 270162 [details] [review]:

You need a PK_CHECK_VERSION in packagekit-refine too, but after that it looks good, thanks.
Comment 19 Richard Hughes 2014-02-25 11:00:01 UTC
Review of attachment 270202 [details] [review]:

Looks good, thanks.
Comment 20 Richard Hughes 2014-02-25 11:00:30 UTC
Review of attachment 270203 [details] [review]:

Looks good, thanks.
Comment 21 Richard Hughes 2014-02-25 11:00:53 UTC
Review of attachment 270204 [details] [review]:

Looks good, thanks.
Comment 22 Richard Hughes 2014-02-25 11:01:08 UTC
Review of attachment 270205 [details] [review]:

Looks good, thanks.
Comment 23 Richard Hughes 2014-02-25 11:01:53 UTC
Review of attachment 270206 [details] [review]:

Looks good, thanks.
Comment 24 Richard Hughes 2014-02-25 11:01:54 UTC
Review of attachment 270206 [details] [review]:

Looks good, thanks.
Comment 25 Richard Hughes 2014-02-25 11:02:25 UTC
Review of attachment 270207 [details] [review]:

Looks good, thanks, although untested.
Comment 26 Richard Hughes 2014-02-25 11:02:40 UTC
Review of attachment 270208 [details] [review]:

Looks good, thanks.
Comment 27 Richard Hughes 2014-02-25 11:02:51 UTC
Review of attachment 270209 [details] [review]:

Looks good, thanks.
Comment 28 Richard Hughes 2014-02-25 11:03:08 UTC
Review of attachment 270210 [details] [review]:

Looks good, thanks.
Comment 29 Richard Hughes 2014-02-25 11:03:23 UTC
Review of attachment 270211 [details] [review]:

Ooops. Looks good, thanks.
Comment 30 Richard Hughes 2014-02-25 11:04:00 UTC
Review of attachment 270212 [details] [review]:

Can you get a string exception for this please -- then looks fine for me.
Comment 31 Kalev Lember 2014-02-25 15:08:35 UTC
Attachment 270203 [details] pushed as 1872665 - details: Fade in the loading spinner
Attachment 270204 [details] pushed as d7627ed - details: Use application/x-executable icon for local packages
Attachment 270205 [details] pushed as c7a3cfd - details: Add CSS for infobar theming
Attachment 270206 [details] pushed as 5b14c4c - details: Show the filename for local package installation
Attachment 270207 [details] pushed as 00e9b2d - details: Align package details as per latest mockups
Attachment 270208 [details] pushed as 7b8e395 - details: Let the 'origin' span 3 columns
Attachment 270209 [details] pushed as 0103089 - details: Remove spacing between infobar labels
Attachment 270210 [details] pushed as 628ac71 - details: Don't show missing history on a local package install
Attachment 270211 [details] pushed as be7cc65 - details: Remove duplicate copy-pasted code
Comment 32 Kalev Lember 2014-02-25 15:21:09 UTC
Thanks for the reviews, both Allan and Richard!

(In reply to comment #16)
> Hmm, OK. Maybe we shouldn't use the name of the software itself then. "Software
> Source Included" and "No Software Source Included"? (I'm open to suggestions!)

What should it say for the standalone repo package, when the whole package is just the repo? We've got 3 different cases, (1) app that has a repo file included, (2) app that doesn't have a repo file included, (3) package with just a repo file.

Also, I am wondering if it might be better to use the existing terminology (software repository) instead of coming up with new (software source).
Comment 33 Jakub Steiner 2014-02-25 18:52:29 UTC
Created attachment 270304 [details] [review]
repositories

- again, mimetype because I can't think of anything more appropriate
Comment 34 Jakub Steiner 2014-02-25 18:53:26 UTC
Comment on attachment 270304 [details] [review]
repositories

Attachment 270304 [details] pushed as ef18672 - repositories
Comment 35 Giovanni Campagna 2014-02-26 16:22:13 UTC
Comment on attachment 270162 [details] [review]
PackageKit: make use of the summary in details, when available

Attachment 270162 [details] pushed as bd655a7 - PackageKit: make use of the summary in details, when available
Comment 36 Kalev Lember 2014-03-03 09:40:17 UTC
(In reply to comment #16)
> "Software Source Included" and "No Software Source Included"? (I'm open to suggestions!)

I've pushed this and another commit to make use of the new icons. Thanks!

(In reply to comment #30)
> Can you get a string exception for this please -- then looks fine for me.

Done:
https://mail.gnome.org/archives/gnome-i18n/2014-March/msg00003.html

We are only in string announcement period though so I only sent out the notifications and didn't ask for a freeze exception. The hard string freeze starts with the .91 release.