After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 724668 - coverage: add missing request
coverage: add missing request
Status: RESOLVED FIXED
Product: gjs
Classification: Bindings
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gjs-maint
gjs-maint
Depends on:
Blocks:
 
 
Reported: 2014-02-18 16:58 UTC by Giovanni Campagna
Modified: 2014-02-18 17:58 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
coverage: add missing request (942 bytes, patch)
2014-02-18 16:58 UTC, Giovanni Campagna 		committed Details | Review

Description Giovanni Campagna 2014-02-18 16:58:05 UTC 
Spotted by running the tests with a libmozjs compiled with
JS_DEBUG and JS_THREADSAFE.
Comment 1 Giovanni Campagna 2014-02-18 16:58:07 UTC 
Created attachment 269579 [details] [review]
coverage: add missing request
Comment 2 Jasper St. Pierre (not reading bugmail) 2014-02-18 17:01:14 UTC 
Review of attachment 269579 [details] [review]:

Can you put the request in gjs_coverage_write_statistics? I'd like for compartments / requests to be as close as possible to the the high-level user API.
Comment 3 Giovanni Campagna 2014-02-18 17:27:13 UTC 
(In reply to comment #2)
> Review of attachment 269579 [details] [review]:
> 
> Can you put the request in gjs_coverage_write_statistics? I'd like for
> compartments / requests to be as close as possible to the the high-level user
> API.

Mh... there is an AutoCompartment call right there.
Comment 4 Jasper St. Pierre (not reading bugmail) 2014-02-18 17:30:21 UTC 
Oh, I forgot I had a few local patches that moved the AutoCompartment to write_statistics.
Comment 5 Jasper St. Pierre (not reading bugmail) 2014-02-18 17:30:51 UTC 
Review of attachment 269579 [details] [review]:

OK for now.
Comment 6 Giovanni Campagna 2014-02-18 17:58:15 UTC 
Attachment 269579 [details] pushed as 5e0248c - coverage: add missing request