After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 724665 - Problems placing thumbnails with RTL on the HTML overview
Problems placing thumbnails with RTL on the HTML overview
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: Overview
git master
Other All
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-02-18 16:41 UTC by Lorenzo Tilve
Modified: 2014-02-19 08:41 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
overview: Place thumbnails and the close-butons according to ltr/rtl (902 bytes, patch)
2014-02-18 16:46 UTC, Lorenzo Tilve 		committed Details | Review

Description Lorenzo Tilve 2014-02-18 16:41:45 UTC 
The HTML overview is not taking properly into consideration RTL/LTR direction for the placement of the thumbnails, which should be arranged from right to left, when the dir="rtl" according to gtk_widget_get_default_direction ().

Something similar applies to the position of the close-button, that on RTL should be placed on the top left corner of the thumbnail.
Comment 1 Lorenzo Tilve 2014-02-18 16:46:55 UTC 
Created attachment 269577 [details] [review]
overview: Place thumbnails and the close-butons according to ltr/rtl

Add CSS rules to avoid the wrong manual floating of the thumbnails
and the close button when dir="rtl".
Comment 2 Yosef Or Boczko 2014-02-18 16:49:25 UTC 
Thanks, works fine for me!
Comment 3 Claudio Saavedra 2014-02-18 22:35:49 UTC 
Review of attachment 269577 [details] [review]:

thanks