GNOME Bugzilla – Bug 724652
Improve the CSS theming of the overview
Last modified: 2014-03-05 16:17:40 UTC
Personally, I find that the opacity is confusing. I'd say that we don't want foreground items to be darkened or shadowed. I asl think we don't want to have a floating close button outside the snapshot thumbnail. Since this is all done through CSS (and the overview is now HTML), I think we have a chance to do something nicely looking here.
I think that with the last changes done on the CSS the result is really nice. Being one who originally liked the close button out, I do prefer how it looks now. However, it seems that the commit e7e72ac6a15 introduced a regression that caused that when the elements were removed from the overview, the layout was not reflowing. There is another minor issue too with regard to the centering of the grid. I'm attaching a small patch for both problems. I will send soon another bigger patch to bring back the behavior of adding new elements to the overview when removing the existing ones.
Created attachment 270048 [details] [review] overview: fix issues on the layout CSS Adding the CSS rules are necessary for doing the animation when removing elements from the overview, and fixing other minor positioning issues.
Theming looks fine to me. Can we close this already?
I don't think the problem is the theming, but a regression in the animation when an item is removed
I reported this bug to deal with the theming improvements. The issues with the animation should have been reported in a different bug. In any case, I think Lorenz and Jakub discussed the animation already.
Created attachment 270983 [details] [review] overview: fix issues on the layout CSS After some iterations discussed on #gnome-design I'm attaching a new version of the patch. Avoided an effect when removing elements that was causing the row to shrink and due to the centering inside the grid. The animation transition was shortened to be done only when the thumbnail is being removed.