GNOME Bugzilla – Bug 724636
v4l2videodec: VP8 KO with playbin
Last modified: 2014-02-25 21:12:43 UTC
Created attachment 269542 [details] [review] v4l2object: do not emit "parsed" caps for vp8 VP8 stream not played with v4l2videodec plugin. Problem is a negotiation issue between matroskademux and v4l2videodec, due to "parsed" emitted in caps by v4l2videodec and not accepted by matroskademux. It seems that VP8 is not "parseable" (cf Bug 637831), so vp8parse has not been developped. The proposed patch consist to not emit "parsed" in caps in case of VP8.
Right, also endup making the same patch yesterday, I like your solution with the flag, though it not a long term one, since there is work being done to add vp8 parsing.
Comment on attachment 269542 [details] [review] v4l2object: do not emit "parsed" caps for vp8 I think this is ok in general. VP8 is unparseable, you need to get it chunked into frames already. The VP8 parser support that is going to be added to the codecparser library is expecting one frame per buffer and only extracting information from them. Most likely there will never be a vp8parse element.
Nicolas, I'm not merging this patch myself because I know you have quite some changes pending. Please just integrate that into your branch :)
yep, thanks, will add up to my branch.
Not has elegant, but forgot to replace it in my branch. I'll try and blend you version into this. Though meanwhile the bug is fixed. commit 82f2bf052add2442244ff1cb553f8861e3dc4857 Author: Nicolas Dufresne <nicolas.dufresne@collabora.com> Date: Tue Feb 11 16:27:08 2014 -0500 v4l2: Don't require parser for VP8 Until GStreamer has one (see bug722760), we should not require a parser for VP8. https://bugzilla.gnome.org/show_bug.cgi?id=722128
Comment on attachment 269542 [details] [review] v4l2object: do not emit "parsed" caps for vp8 commit a2d00122ed7c6ba57956eddbc3d7b3719da16198 Author: Hugues Fruchet <hugues.fruchet@st.com> Date: Tue Feb 25 16:10:54 2014 -0500 v4l2object: do not emit "parsed" caps for vp8 VP8 doesn't require parsing (vp8parse doesn't exist, so negotiation with demux fails if "parsed" is set in caps). https://bugzilla.gnome.org/show_bug.cgi?id=724636