GNOME Bugzilla – Bug 724627
Playlists UX review
Last modified: 2014-04-22 15:49:25 UTC
I've quickly tested the new playlists functionality that has just landed. In general it looks good, but there are some things that could be improved. Selection Mode * Action bars (the toolbar at the bottom of the screen) in selection mode are missing a top stroke. * In artist view, entering selection mode causes the sidebar to expand and the content of the window to jump to the right. The sidebar should never change width. Playlists Dialog * The select button is sensitive when "New Playlist" is selected - it should be insensitive. * The rows look too tall, and the text box when entering a new name is *really* too tall. In general it would be better to use ListBox here, and have separators between each row. Otherwise, you could just make the rows shorter. * There's an odd amount of padding around the list. It should be something like 12px all the way round. Playlists View * The gear button has really strange styling. It looks like it has the background from a round button, even though it is square. If it is hard to do something custom, keep it simple and just use the standard style. * If I delete a playlist, sometimes the playlist doesn't disappear. Sometimes the track list disappears but the "header" from above the list remains.
Created attachment 269638 [details] [review] Makes the select button insensitive while creating a new playlist Fixes one of the issues in the UX review bugs
Review of attachment 269638 [details] [review]: Has some glitch , need to add a couple more conditional statements.
Review of attachment 269638 [details] [review]: ::: gnomemusic/widgets.py @@ +680,3 @@ if self.model.get_value(_iter, 1): self.view.set_cursor(path, column, True) + self._select_button.set_sensitive(False); You should add a new line below at least
Created attachment 271319 [details] [review] Make select button insensitive while creating New Playlist
Fixed with Vadim's suggestion, removed the unnecessary semicolon, and fixed sensitivity when selecting a playlist (in previous patch, Select becomes insensitive forever after selecting New Playlist).
Review of attachment 271319 [details] [review]: Committed as https://git.gnome.org/browse/gnome-music/commit/?id=acd735e
The fixes for the gear button (I changed it to a square button) has only small changes in the GtkBuilder and CSS files, while the jumping sidebar of the Artists view in selection mode needs 2 additional lines to view.py, should I ask for Hard Code and UI freeze breaks? As for the Playlist dialog, aside from the padding, it would probably change a lot of code, so I think it would be better if we just fix in the 3.14 cycle. It is using TreeView for compatibility for GTK+ 3.8, and wasn't fixed before merging. I haven't fixed the padding yet though.
Fixes for most of the issues are pushed to branch wip/playlist-ux-fixes. I'll ask for Hard Code and UI Freeze Break tomorrow for these patches.
Just an update on this one: we decided to postpone the fixes to 3.12.1 (except changes which requires a lot of change, like the Add to Playlists dialog) instead of requesting for freeze breaks. The fixes are now in master branch.
Clarification: fixes except for issues in Add to Playlists dialog and the second issue with Playlists View.
Pushed Arnel's patches to master, all issues seem to be fixed except: (In reply to comment #0) > * The gear button has really strange styling. It looks like it has the > background from a round button, even though it is square. If it is hard to do > something custom, keep it simple and just use the standard style. > * If I delete a playlist, sometimes the playlist doesn't disappear. Sometimes > the track list disappears but the "header" from above the list remains. I guess we either should come up with some pre-defined non-removable playlists - or 'No playlists' view. Allan, any suggestions?
(In reply to comment #11) > Pushed Arnel's patches to master, all issues seem to be fixed except: > (In reply to comment #0) > > * The gear button has really strange styling. It looks like it has the > > background from a round button, even though it is square. If it is hard to do > > something custom, keep it simple and just use the standard style. > > * If I delete a playlist, sometimes the playlist doesn't disappear. Sometimes > > the track list disappears but the "header" from above the list remains. > > I guess we either should come up with some pre-defined non-removable playlists > - or 'No playlists' view. Allan, any suggestions? I'd do a no playlists view for now. Maybe we want to look at automatic playlists in the future, but that'll take a bit of thought. I added an empty state to the wireframes: https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/music/wire-playlists.png
I reported the outstanding issue as bug 728736. Let's close this as done for now.