After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 724573 - Fix some runtime warnings
Fix some runtime warnings
Status: RESOLVED FIXED
Product: gnome-settings-daemon
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-settings-daemon-maint
gnome-settings-daemon-maint
Depends on:
Blocks:
 
 
Reported: 2014-02-17 19:20 UTC by Cosimo Cecchi
Modified: 2014-02-18 08:09 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
updates: don't use changed signal on UpClient (1.62 KB, patch)
2014-02-17 19:20 UTC, Cosimo Cecchi
committed Details | Review
rfkill: fix signal emission with no connection (1.52 KB, patch)
2014-02-17 19:20 UTC, Cosimo Cecchi
rejected Details | Review
rfkill: clear id after unowning bus name (1.08 KB, patch)
2014-02-17 19:20 UTC, Cosimo Cecchi
committed Details | Review

Description Cosimo Cecchi 2014-02-17 19:20:13 UTC
See attached patches
Comment 1 Cosimo Cecchi 2014-02-17 19:20:15 UTC
Created attachment 269457 [details] [review]
updates: don't use changed signal on UpClient

This was removed recently from upower; connect to the notification of
the property we're interested in instead.
Comment 2 Cosimo Cecchi 2014-02-17 19:20:18 UTC
Created attachment 269458 [details] [review]
rfkill: fix signal emission with no connection

Since the asynchronous session bus request might still not have
completed by the time we try to sync one of the properties coming from
ModemManager/NetworkManager, move the (connection != NULL) check in
engine_properties_changed(), to avoid trying to emit a signal on a NULL
connection.
Comment 3 Cosimo Cecchi 2014-02-17 19:20:22 UTC
Created attachment 269459 [details] [review]
rfkill: clear id after unowning bus name

Or we'll try to unown the same bus id again next time
gsd_rfkill_manager_stop() is called.
Comment 4 Bastien Nocera 2014-02-18 06:47:11 UTC
Review of attachment 269458 [details] [review]:

Sure.
Comment 5 Bastien Nocera 2014-02-18 06:47:22 UTC
Review of attachment 269459 [details] [review]:

Yep.
Comment 6 Bastien Nocera 2014-02-18 08:04:56 UTC
Comment on attachment 269458 [details] [review]
rfkill: fix signal emission with no connection

Already fixed in bug 712168.
Comment 7 Bastien Nocera 2014-02-18 08:07:25 UTC
Review of attachment 269457 [details] [review]:

Looks good.
Comment 8 Bastien Nocera 2014-02-18 08:09:05 UTC
Attachment 269457 [details] pushed as 772aaac - updates: don't use changed signal on UpClient
Attachment 269459 [details] pushed as 04cfff8 - rfkill: clear id after unowning bus name