After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 724540 - pls: Return an error when the entry media is of the wrong type
pls: Return an error when the entry media is of the wrong type
Status: RESOLVED FIXED
Product: grilo
Classification: Other
Component: core
unspecified
Other All
: Normal normal
: ---
Assigned To: grilo-maint
grilo-maint
Depends on:
Blocks:
 
 
Reported: 2014-02-17 13:32 UTC by Bastien Nocera
Modified: 2014-02-18 12:27 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
pls: C89 compilation fixes (1.15 KB, patch)
2014-02-17 13:32 UTC, Bastien Nocera 		committed Details | Review
pls: Return an error when the entry media is of the wrong type (1.55 KB, patch)
2014-02-17 13:32 UTC, Bastien Nocera 		needs-work Details | Review
pls: Return an error when the entry media is of the wrong type (1.61 KB, patch)
2014-02-18 12:25 UTC, Juan A. Suarez Romero 		committed Details | Review

Description Bastien Nocera 2014-02-17 13:32:49 UTC 
So that we can't add directories to Totem.
Comment 1 Bastien Nocera 2014-02-17 13:32:52 UTC 
Created attachment 269388 [details] [review]
pls: C89 compilation fixes

Move declaration to the top of the block.
Comment 2 Bastien Nocera 2014-02-17 13:32:58 UTC 
Created attachment 269389 [details] [review]
pls: Return an error when the entry media is of the wrong type

Ensure that the type of the returned media is GrlMediaBox when
the detected type is GrlMediaBox.
Comment 3 Juan A. Suarez Romero 2014-02-18 12:10:16 UTC 
Comment on attachment 269388 [details] [review]
pls: C89 compilation fixes

Attachment 269388 [details] pushed as d03820f - pls: C89 compilation fixes
Comment 4 Juan A. Suarez Romero 2014-02-18 12:11:33 UTC 
Review of attachment 269389 [details] [review]:

::: configure.ac
@@ +47,3 @@
 # Grilo Pls library
 
+GRLPLS_VERSION=0.2.8

The libraries follow their own version. So this should be 0.2.1
Comment 5 Juan A. Suarez Romero 2014-02-18 12:25:45 UTC 
Created attachment 269541 [details] [review]
pls: Return an error when the entry media is of the wrong type

Ensure that the type of the returned media is GrlMediaBox when
the detected type is GrlMediaBox.

https://bugzilla.gnome.org/show_bug.cgi?id=724540

Signed-off-by: Juan A. Suarez Romero <jasuarez@igalia.com>
Comment 6 Juan A. Suarez Romero 2014-02-18 12:26:55 UTC 
Attachment 269541 [details] pushed as 1213088 - pls: Return an error when the entry media is of the wrong type