After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 724487 - Minor ods roundtrip issues
Minor ods roundtrip issues
Status: RESOLVED FIXED
Product: Gnumeric
Classification: Applications
Component: import/export OOo / OASIS
git master
Other All
: Normal normal
: ---
Assigned To: Andreas J. Guelzow
Jody Goldberg
Depends on:
Blocks:
 
 
Reported: 2014-02-16 15:14 UTC by Morten Welinder
Modified: 2014-02-17 02:31 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch fixing the second half of the issue at hand (2.77 KB, patch)
2014-02-16 19:59 UTC, Andreas J. Guelzow
none Details | Review
screenshot (62.28 KB, image/png)
2014-02-16 22:11 UTC, Andreas J. Guelzow
  Details

Description Morten Welinder 2014-02-16 15:14:57 UTC
From t6500:

-  <gnm:Geometry Width="960" Height="434"/>
+  <gnm:Geometry Width="0" Height="0"/>


-        <gnm:Header Left="" Middle="&amp;[TAB]" Right=""/>
-        <gnm:Footer Left="" Middle="Page &amp;[PAGE]" Right=""/>
+        <gnm:Header Left="" Middle="&amp;[tab]" Right=""/>
+        <gnm:Footer Left="" Middle="Page &amp;[page]" Right=""/>
Comment 1 Andreas J. Guelzow 2014-02-16 19:59:12 UTC
Created attachment 269325 [details] [review]
patch fixing the second half of the issue at hand

This patch fixes the second half of the issue at hand. I can't commit at this time.
Comment 2 Morten Welinder 2014-02-16 20:26:23 UTC
Why are these keywords translated?  Do we really store them translated?
Comment 3 Andreas J. Guelzow 2014-02-16 20:30:19 UTC
I didn't think about that, but surely we do not want them to be translated.
Comment 4 Andreas J. Guelzow 2014-02-16 22:11:31 UTC
Created attachment 269339 [details]
screenshot

We seem to render the translated tags just fine.
Comment 5 Andreas J. Guelzow 2014-02-16 22:19:45 UTC
And according to render_opcode in print-info.c we definitely have translated ops inside Gnumeric.

Note that we do not store them translated in ODF, we translate on reading. I do not know about the .gnumeric format.
Comment 6 Morten Welinder 2014-02-17 01:17:54 UTC
Committed.

Some day, with our endless free time, we really ought to revisit keeping
translate keywords around.  But it's evidently not ods' fault.
Comment 7 Andreas J. Guelzow 2014-02-17 02:23:41 UTC
This does not look like t6500 to me

Andreas
Comment 8 Andreas J. Guelzow 2014-02-17 02:31:01 UTC
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.