After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 724437 - Content-Disposition inline confuses message formatter
Content-Disposition inline confuses message formatter
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: Mailer
3.10.x (obsolete)
Other Linux
: Normal normal
: ---
Assigned To: evolution-mail-maintainers
Evolution QA team
Depends on:
Blocks:
 
 
Reported: 2014-02-15 20:50 UTC by benh
Modified: 2014-02-19 00:09 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Screen capture of the email window with attachment instead of inline display (51.49 KB, image/png)
2014-02-15 20:50 UTC, benh
Details
Email causing the problem (32.87 KB, application/mbox)
2014-02-15 20:52 UTC, benh
Details

Description benh 2014-02-15 20:50:46 UTC
Created attachment 269228 [details]
Screen capture of the email window with attachment instead of inline display

I am regularly getting patch emails display as attachments instead of inline which makes things really hard to review and reply to. I am told by other kernel folks to blame my MUA and that they work fine for others, so here I am :-)

I'll attach a screen capture to show the problem and the source email. Evolution
is version 3.10.3 (it happened with 3.8.4 as well).
Comment 1 benh 2014-02-15 20:52:12 UTC
Created attachment 269229 [details]
Email causing the problem
Comment 2 Matthew Barnes 2014-02-15 22:23:25 UTC
Sample email displays text/plain part inline for me with 3.11.90, although seems to be unnecessarily nested a level.
Comment 3 benh 2014-02-15 23:16:30 UTC
Hrm, ok, 3.10 is all I could find in ubuntu gnome3 ppa (corporate approved distro is ubuntu...), any recommendation on a good ppa with 3.11 ?
Comment 4 benh 2014-02-15 23:29:35 UTC
I found fta's PPA which has it but due to some kind of dependency trainwreck around libgoa, it won't install. Somebody had the bright idea of creating an override on libgoa-1.0 called libgoa-1.0-0b which doesn't satisfy the dependency for evolution-data-server, and generally speaking turns the whole thing into hell.

Looks like I'll have to live either live with it until gnome3 ppa gets 3.11 or until I build it myself (which I'm also not looking forward to).
Comment 5 Milan Crha 2014-02-18 10:05:37 UTC
The email is quite simple, it's only a text/plain message, like any other email, with one exception:

   Content-Type: text/plain; charset=UTF-8
   Content-Disposition: inline; filename=this_powerpc

the Content-Disposition marks this message as "to be shown inline". When I drop the 'inline' flag from the Content-Disposition, then the message body is drawn properly, without sub-button (to understand, your screenshot from comment #0 shows a button for an attachment which is disabled, while I, and also Matthew, see the button enabled, under it another button with the same line, and only under it the actual message body.
Comment 6 Milan Crha 2014-02-18 10:39:49 UTC
(In reply to comment #5)
> ...your screenshot from comment #0 shows a button for an attachment which
> is disabled...

Aah, I see why it is, you either do not have the module-text-highlight installed, or the highlight binary itself, which makes the button disabled.

That means we've two issues here:
a) doubled attachment button with text-highlight module
b) inline text/plain not shown at all without text-highlight module
Comment 7 Milan Crha 2014-02-18 11:39:55 UTC
This is a regression after commit [1], which causes doubled attachment encapsulation, which broke the rendering. I fixed it at [2]:

Created commit bc2fd7b in evo master (3.11.91+) [2]

[1] https://git.gnome.org/browse/evolution/commit/?id=514736f
[2] https://git.gnome.org/browse/evolution/commit/?id=bc2fd7b
Comment 8 benh 2014-02-19 00:09:47 UTC
Looks like i'll have to wait for some usable 3.11 PPA, thanks guys !