After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 724434 - Build failure in gio/gresolver.c
Build failure in gio/gresolver.c
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: gio
2.39.x
Other FreeBSD
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2014-02-15 18:56 UTC by Koop Mast (kwm)
Modified: 2014-02-15 23:36 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix build by replacing EAI_NODATA with EAI_NONAME (782 bytes, patch)
2014-02-15 18:58 UTC, Koop Mast (kwm) 		committed Details | Review

Description Koop Mast (kwm) 2014-02-15 18:56:02 UTC 
After https://git.gnome.org/browse/glib/commit/gio/gresolver.c?id=5575a3e9cb8ec3d0f0f373cb64e6fedc4c72c0f5 this won't build on FreeBSD due to EAI_NODATA being #if 0 in our netdb.h header with the comment that it is obsoleted.
Comment 1 Koop Mast (kwm) 2014-02-15 18:58:47 UTC 
Created attachment 269222 [details] [review]
Fix build by replacing EAI_NODATA with EAI_NONAME
Comment 2 Allison Karlitskaya (desrt) 2014-02-15 20:01:40 UTC 
On Linux:

# define EAI_NONAME       -2    /* NAME or SERVICE is unknown.  */
# ifdef __USE_GNU
#  define EAI_NODATA      -5    /* No address associated with NAME.  */


They're not the same, but since we're just querying the string associated with one of these, I guess this is fine.

I'll leave it to danw to ACK the fix since he wrote this, though.
Comment 3 Koop Mast (kwm) 2014-02-15 20:08:51 UTC 
For completeness sake this are the lines on FreeBSD.
#if 0
/* obsoleted */
#define EAI_NODATA       7      /* no address associated with hostname */
#endif
#define EAI_NONAME       8      /* hostname nor servname provided, or not known */
Comment 4 Dan Winship 2014-02-15 23:36:20 UTC 
pushed. thanks