GNOME Bugzilla – Bug 724430
Remove check for libvala in configure.ac
Last modified: 2014-02-18 14:28:08 UTC
When checking if a supported version of Vala is installed, Grilo looks for libvala-0.XX in configure.ac. However only valac, vapigen and vala-gen-introspect seem to be required. Grilo doesn't seem to need libvala at all so that check is unnecessary and only forces people to have the library development files installed. I'm not sure what's the recommended way to check for the installed valac version in configure.ac, but valac --version is probably good enough and doesn't require you to update configure.ac every time a new Vala version is released.
Created attachment 269552 [details] [review] build: drop libvala requirement Only valac, vapigen and vala-gen-introspect are required.
Attachment 269552 [details] pushed as 6f96c5f - build: drop libvala requirement
The problem with this fix is that it doesn't auto-detect Vala anymore, configure will fail if Vala is not installed unless you pass --disable-vala.
Right. For now, let's downstream to add Vala as the requirement in the packaging, or passing "--disable-vala". I'll improve the auto-detect for next releases.
I personally don't need auto detection so I'm fine with that, but I guess the configure help should be updated to state that --enable-vala is now the default.
Filed bug #724648 to track it