After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 724417 - glib master build broken on OpenBSD
glib master build broken on OpenBSD
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: build
2.39.x
Other OpenBSD
: Normal critical
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2014-02-15 12:34 UTC by Antoine Jacoutot
Modified: 2014-02-15 15:33 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
only '#pragma GCC' outside of functions (2.26 KB, patch)
2014-02-15 13:44 UTC, Allison Karlitskaya (desrt) 		committed Details | Review

Description Antoine Jacoutot 2014-02-15 12:34:35 UTC 
Hi.

This commit broke glib master on OpenBSD:
From ddf82a25761ed6aae17e478ab5d3096275b32b35 Mon Sep 17 00:00:00 2001
From: Ryan Lortie <desrt@desrt.ca>
Date: Sun, 08 Dec 2013 19:22:51 +0000
Subject: [PATCH] Fix trivial non literal format uses


test-printf.c: In function 'test_d':
test-printf.c:191: error: #pragma GCC diagnostic not allowed inside functions
test-printf.c:192: error: #pragma GCC diagnostic not allowed inside functions
test-printf.c:202: error: #pragma GCC diagnostic not allowed inside functions
Makefile:1846: recipe for target 'test-printf.o' failed
gmake[5]: *** [test-printf.o] Error 1
Comment 1 Allison Karlitskaya (desrt) 2014-02-15 13:44:52 UTC 
Created attachment 269196 [details] [review]
only '#pragma GCC' outside of functions

Don't use #pragma GCC inside of function scope.




Can you check if this fixes the issue for you?
Comment 2 Antoine Jacoutot 2014-02-15 14:47:38 UTC 
> Can you check if this fixes the issue for you?

Yup it does, thanks a lot :-)
Comment 3 Allison Karlitskaya (desrt) 2014-02-15 15:33:07 UTC 
Attachment 269196 [details] pushed as 08533ca - only '#pragma GCC' outside of functions