After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 724411 - GtkAboutDialog: License visible even if not set and predefined license display broken
GtkAboutDialog: License visible even if not set and predefined license displa...
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: Other
3.11.x
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2014-02-15 10:58 UTC by Christoph Reiter (lazka)
Modified: 2014-02-22 02:24 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Christoph Reiter (lazka) 2014-02-15 10:58:09 UTC 
The following works in 3.10 but not with trunk.

* Not setting any license still shows the license button with an empty text field: http://imgur.com/CUiPFqd

* Using gtk_about_dialog_set_license_type(GTK_LICENSE_GPL_2_0) shows a broken link: http://imgur.com/gMNrL4t
Comment 1 Matthias Clasen 2014-02-15 23:10:53 UTC 
hmm, I can't reproduce this here. I guess this might be the python bindings interfering and setting the license property to an empty string instead of NULL.
No idea how you could get the license tab to show while the license type is set to GPL2.

I've pushed a possible fix for the empty license tab.
Comment 2 Christoph Reiter (lazka) 2014-02-16 10:07:43 UTC 
Thanks for looking into it.

No, that wasn't it. text is NULL and type UNKNOWN and pygobject doesn't have AboutDialog overrides.

I did some more testing and the license tab shows once the credits tab is shown (either artists, authors or translator_credits is set)
Comment 3 Matthias Clasen 2014-02-18 03:34:01 UTC 
not seeing that here.
Comment 4 Christoph Reiter (lazka) 2014-02-22 00:18:33 UTC 
Sorry for not trying to reduce the example earlier, the problem is the show_all() call.

#################

from gi.repository import Gtk
dialog = Gtk.AboutDialog()
dialog.set_artists("foo")
dialog.show_all()
Gtk.main()

#################

If this isn't supposed to work, please close this bug.