After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 724382 - server: Process SIGUSR1 more carefully
server: Process SIGUSR1 more carefully
Status: RESOLVED FIXED
Product: gdm
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: GDM maintainers
GDM maintainers
Depends on:
Blocks:
 
 
Reported: 2014-02-14 20:49 UTC by Jasper St. Pierre (not reading bugmail)
Modified: 2014-02-14 20:50 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
main: Remove debug log toggle on SIGUSR1 (1.28 KB, patch)
2014-02-14 20:49 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review
server: Process SIGUSR1 more carefully (5.82 KB, patch)
2014-02-14 20:49 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review

Description Jasper St. Pierre (not reading bugmail) 2014-02-14 20:49:29 UTC 
See patches.
Comment 1 Jasper St. Pierre (not reading bugmail) 2014-02-14 20:49:31 UTC 
Created attachment 269144 [details] [review]
main: Remove debug log toggle on SIGUSR1

Trying to integrate the slave into the main daemon means that we
need to respond to USR1 as it's the signal Xorg sends when the
X server is ready.
Comment 2 Jasper St. Pierre (not reading bugmail) 2014-02-14 20:49:35 UTC 
Created attachment 269145 [details] [review]
server: Process SIGUSR1 more carefully

If the slave is removed as a separate process, it means that we need
to be more careful with our handling of SIGUSR1. If multiple X servers
are launched at once, we need to use siginfo_t to get the PID of the
thing that sent the user signal, and make sure we signal the correct
GdmServer.

glib doesn't have native siginfo support, so do it ourselves by using
a worker thread that spins around waiting for sigwaitinfo.
Comment 3 Jasper St. Pierre (not reading bugmail) 2014-02-14 20:49:57 UTC 
Attachment 269144 [details] pushed as 98a32e4 - main: Remove debug log toggle on SIGUSR1
Attachment 269145 [details] pushed as 956d7d1 - server: Process SIGUSR1 more carefully