GNOME Bugzilla – Bug 724314
[review] dcbw/wwan-fu: various fixes for mobile broadband
Last modified: 2014-02-21 16:21:31 UTC
Various WWAN-related fixes.
> mobile: fix removal of ethernet interfaces owned by modems nm_modem_owns_port() is clearly set up to let the modem claim multiple devices, but NMManager will only ever remove one of them. That seems like a bug?
(In reply to comment #1) > > mobile: fix removal of ethernet interfaces owned by modems > > nm_modem_owns_port() is clearly set up to let the modem claim multiple devices, > but NMManager will only ever remove one of them. That seems like a bug? Fixed. One new patch added as well, to use the gateway if we get one.
>> mobile: fix removal of ethernet interfaces owned by modems - owns = (strcmp (iface, ports[i].name) == 0); + owns = (g_strcmp0 (iface, ports[i].name) == 0); Those devices used by the modem, are they always unusable for us, or only as long as the modem is active? i.e. should we re-add them, after the modem gets removed? >> mobile: use gateway returned from ModemManager pushed a fixup!. Other then that, looks fine
looks good to me
Merged.