After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 724314 - [review] dcbw/wwan-fu: various fixes for mobile broadband
[review] dcbw/wwan-fu: various fixes for mobile broadband
Status: RESOLVED FIXED
Product: NetworkManager
Classification: Platform
Component: Mobile broadband
unspecified
Other Linux
: Normal normal
: ---
Assigned To: NetworkManager maintainer(s)
NetworkManager maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2014-02-13 19:00 UTC by Dan Williams
Modified: 2014-02-21 16:21 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Dan Williams 2014-02-13 19:00:02 UTC
Various WWAN-related fixes.
Comment 1 Dan Winship 2014-02-14 15:11:43 UTC
> mobile: fix removal of ethernet interfaces owned by modems

nm_modem_owns_port() is clearly set up to let the modem claim multiple devices, but NMManager will only ever remove one of them. That seems like a bug?
Comment 2 Dan Williams 2014-02-18 20:12:55 UTC
(In reply to comment #1)
> > mobile: fix removal of ethernet interfaces owned by modems
> 
> nm_modem_owns_port() is clearly set up to let the modem claim multiple devices,
> but NMManager will only ever remove one of them. That seems like a bug?

Fixed.

One new patch added as well, to use the gateway if we get one.
Comment 3 Thomas Haller 2014-02-20 21:22:42 UTC
>> mobile: fix removal of ethernet interfaces owned by modems

-         owns = (strcmp (iface, ports[i].name) == 0);
+         owns = (g_strcmp0 (iface, ports[i].name) == 0);

Those devices used by the modem, are they always unusable for us, or only as long as the modem is active? i.e. should we re-add them, after the modem gets removed?



>> mobile: use gateway returned from ModemManager

pushed a fixup!.




Other then that, looks fine
Comment 4 Dan Winship 2014-02-21 14:14:21 UTC
looks good to me
Comment 5 Dan Williams 2014-02-21 16:21:31 UTC
Merged.