After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 724310 - fetcher: set timeouts on HTTP connections
fetcher: set timeouts on HTTP connections
Status: RESOLVED FIXED
Product: ostree
Classification: Infrastructure
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: OSTree maintainer(s)
OSTree maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2014-02-13 17:06 UTC by Daniel Drake
Modified: 2014-02-13 17:23 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
fetcher: set timeouts on HTTP connections (1.53 KB, patch)
2014-02-13 17:06 UTC, Daniel Drake 		committed Details | Review

Description Daniel Drake 2014-02-13 17:06:50 UTC 
Soup has no HTTP timeouts by default.
Set these, maybe it helps with some ostree fetch hangs we are
seeing.
Comment 1 Daniel Drake 2014-02-13 17:06:52 UTC 
Created attachment 269043 [details] [review]
fetcher: set timeouts on HTTP connections

We're seeing some hangs while ostree is fetching updates.
I imagine the fact that SoupSessionAsync has no timeout by default
could be the cause of this.

Set timeout values to 60 seconds, which is the default for the new
SoupSession API which we may switch to later.
Comment 2 Colin Walters 2014-02-13 17:16:28 UTC 
Review of attachment 269043 [details] [review]:

Yes, looks reasonable to me.  Thanks!  

I think at least yum has logic to detect "too slow" connections, something like "under 1000 bytes/sec".

(I'd consider switching to a newer libsoup, it looks like both Debian jessie and RHEL 7 beta have glib 2.36, and both have at least libsoup-2.42)
Comment 3 Daniel Drake 2014-02-13 17:23:07 UTC 
Comment on attachment 269043 [details] [review]
fetcher: set timeouts on HTTP connections

Thanks for the fast review, pushed.