Created attachment 269026 [details] [review]
ephy-find-toolbar: Add a count matches label

Note - there is a problem with the patch, with centering the entry and the label.

Created attachment 269107 [details] [review]
ephy-find-toolbar: Add a count matches label

Review of attachment 269107 [details] [review]:

You need a designer to look at this and be OK with it.

::: embed/ephy-find-toolbar.c
@@ +252,3 @@
+		gchar *text;
+
+		text = g_strdup_printf (ngettext ("%u matches found", "%u matches found", n_matches), n_matches);

Shouldn't the first msgid be in singular?

Created attachment 269380 [details] [review]
ephy-find-toolbar: Add a count matches label

Review of attachment 269380 [details] [review]:

Same as I already said.

::: embed/ephy-find-toolbar.c
@@ +43,3 @@
 	GtkWidget *next;
 	GtkWidget *prev;
+	GtkWidget *count_matches;

I think the variable name should be matches_count.

@@ +248,3 @@
+
+        if (n_matches == 0) {
+                gtk_label_set_text (GTK_LABEL (priv->count_matches), _("No matches were found"));

I think it should say "No matches found", otherwise the verb is in transitive form (iirc).

Created attachment 269383 [details] [review]
ephy-find-toolbar: Add a count matches label

Review of attachment 269383 [details] [review]:

Sorry for the huge delay. :(

I don't think we need designer approval for a change this small: it's a nifty addition we should have. But the presence of the label should not change the position of the GtkEntry, since it looks jarring for the position of the GtkEntry to change as the number of search results changes. The GtkEntry should stay centered at all times, and the label should just live off to the right.

::: embed/ephy-find-toolbar.c
@@ +248,3 @@
+
+        if (n_matches == 0) {
+                gtk_label_set_text (GTK_LABEL (priv->matches_count), _("No matches found"));

For some reason, the "No matches found" label never appears for me. I think it's important to display this label, so we should figure out why.

*** Bug 756358 has been marked as a duplicate of this bug. ***

-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/epiphany/issues/227.