After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 724283 - Consider axing EXTRA_DAEMON_LIBS
Consider axing EXTRA_DAEMON_LIBS
Product: gdm
Classification: Core
Component: general
Other All
: Normal normal
: ---
Assigned To: GDM maintainers
GDM maintainers
: 724276 (view as bug list)
Depends on:
Reported: 2014-02-13 12:13 UTC by Allison Karlitskaya (desrt)
Modified: 2014-02-25 21:51 UTC
See Also:
GNOME target: ---
GNOME version: ---

Stop using LDFLAGS for libraries (2.44 KB, patch)
2014-02-25 21:44 UTC, Allison Karlitskaya (desrt)
committed Details | Review

Description Allison Karlitskaya (desrt) 2014-02-13 12:13:51 UTC
This was introduced for probably-no-longer-relevant reasons in bug 85785:

# Note that these libs are in LDFLAGS because they should come before
# everything else on the link line as they may override stuff
gdm_LDFLAGS =                           \
        $(EXTRA_DAEMON_LIBS)                    \

Maybe it's time to remove it.
Comment 1 Allison Karlitskaya (desrt) 2014-02-25 21:44:54 UTC
Created attachment 270328 [details] [review]
Stop using LDFLAGS for libraries

Originally, EXTRA_*_LIBS was introduced as a way to get certain
libraries to the front of the line when invoking the linker in order to
control which version of a library we got.  See bug 85785 for the
history there.

This is probably no longer needed, so officially declare that the only
thing that the EXTRA_ variables mean is "not from pkg-config".

Move all of the EXTRA_*_LIBS from LDFLAGS to _LDADD, along with some
other things that were improperly in LDFLAGS.
Comment 2 Ray Strode [halfline] 2014-02-25 21:46:45 UTC
Review of attachment 270328 [details] [review]:

do it!
Comment 3 Allison Karlitskaya (desrt) 2014-02-25 21:47:42 UTC
Attachment 270328 [details] pushed as 9a23fcc - Stop using LDFLAGS for libraries
Comment 4 Allison Karlitskaya (desrt) 2014-02-25 21:51:26 UTC
*** Bug 724276 has been marked as a duplicate of this bug. ***