After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 724255 - mpegts: Provide original binary data in the public API
mpegts: Provide original binary data in the public API
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal enhancement
: 1.3.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-02-12 23:48 UTC by Brendan Long
Modified: 2014-02-20 16:41 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Add gst_mpegts_section_get_data() (1.53 KB, patch)
2014-02-13 00:17 UTC, Brendan Long
none Details | Review

Description Brendan Long 2014-02-12 23:48:24 UTC
I'm working on providing MPEG-TS PMT's in WebKit:

https://bugs.webkit.org/show_bug.cgi?id=122001

Convenient, GStreamer provides the PMT. Inconveniently, it's pre-parsed. The original binary data is available, but it's marked /*< private >*/. Specifically I'm referring to GstMpegTsSection's "data" and "section_length" members.

Since the data is already there, it would be nice if I could just use it. Is there any chance of either making those public, or adding functions to access them (ex: gst_mpegts_section_get_data() and gst_mpegts_section_get_length())?
Comment 1 Tim-Philipp Müller 2014-02-12 23:57:58 UTC
Something that works nicely with bindings please, e.g. a _get_bytes() that returns a GBytes * or so.
Comment 2 Brendan Long 2014-02-13 00:17:19 UTC
Created attachment 268965 [details] [review]
Add gst_mpegts_section_get_data()

Like this?
Comment 3 Edward Hervey 2014-02-20 12:20:17 UTC
commit cd3c3ebf0140a54625f95ae558686868edbe9a0a
Author: Brendan Long <self@brendanlong.com>
Date:   Wed Feb 12 18:15:44 2014 -0600

    mpegts: Add gst_mpegts_section_get_data, to allow us to get the original binary section data.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=724255
Comment 4 Brendan Long 2014-02-20 16:32:43 UTC
Do you plan to include this in the 1.2.4 release?
Comment 5 Tim-Philipp Müller 2014-02-20 16:41:25 UTC
We usually don't add API in a stable bug-fix series.