After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 724228 - Remove 'now playing' from the app menu
Remove 'now playing' from the app menu
Status: RESOLVED FIXED
Product: gnome-music
Classification: Applications
Component: general
3.11.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-music-maint
gnome-music-maint
3.12
Depends on:
Blocks:
 
 
Reported: 2014-02-12 12:15 UTC by Jakub Steiner
Modified: 2014-02-25 10:56 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Removes now playing from app menu (2.57 KB, patch)
2014-02-22 11:32 UTC, Ishaan
needs-work Details | Review
Removes 'now playing' from app-menu (1.78 KB, patch)
2014-02-24 18:58 UTC, Ishaan
none Details | Review

Description Jakub Steiner 2014-02-12 12:15:05 UTC
Maybe a case of an unimplemented feature/placeholder, but "now playing" in the app menu doesn't take me anywhere.

While it may have been an initial design, app menu should not be used for often performed actions. I think getting to the context of a currently playing song is quite an often performed action (giving up on quest to find a song and wanting to go back to the currently playing context). 

The album art in the playback toolbar is a perfect location for this action, despite having low initial discoverability. We need to do a better job communicating what kind of songset is being played in the playback toolbar, but that's perhaps a different issue.

Clicking on the album art/songname in the playback toolbar should take me to the view that initiated playback, so that I get the original context.
Comment 1 Jakub Steiner 2014-02-12 12:23:20 UTC
Filed bug #724229 for the playback buffer indication.
Comment 2 Ishaan 2014-02-22 11:32:54 UTC
Created attachment 269987 [details] [review]
Removes now playing from app menu

I have just commented out the UI element and the action listener to get rid of the now playing in the app-menu. It can be re-added by just uncommenting them.

Files affected:
application.py
data/app-menu.ui
Comment 3 Vadim Rutkovsky 2014-02-22 22:39:13 UTC
Review of attachment 269987 [details] [review]:

We don't need extra comments in out code if we have git revert. Also, this change in INSTALL is completely unnecessary
Comment 4 Ishaan 2014-02-24 18:58:19 UTC
Created attachment 270171 [details] [review]
Removes 'now playing' from app-menu

Removed the code this time. No comments.

The INSTALL file change happened automatically after the make.
Comment 5 Vadim Rutkovsky 2014-02-25 10:56:57 UTC
Pushed as https://git.gnome.org/browse/gnome-music/commit/?id=9f570ab