After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 724197 - tinderbox reports 'mac os x' when it's not
tinderbox reports 'mac os x' when it's not
Status: RESOLVED DUPLICATE of bug 742267
Product: jhbuild
Classification: Infrastructure
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Jhbuild maintainers
Jhbuild QA
Depends on:
Blocks:
 
 
Reported: 2014-02-12 00:02 UTC by Allison Karlitskaya (desrt)
Modified: 2015-01-03 20:33 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Allison Karlitskaya (desrt) 2014-02-12 00:02:37 UTC 
This code:

    osx = commands.getoutput('sw_vers -productVersion')
    if osx:
        return 'Mac OS X ' + osx;

in tinderbox.py results in seeing this on the summary page:

Distribution       Mac OS X sw_vers: not found

if the lsb/os-release checks above it fail.
Comment 1 Allison Karlitskaya (desrt) 2014-02-12 00:03:51 UTC 
The output of 'uname' or the value of python's "sys.platform" would both probably make reasonable fallback values...
Comment 2 John Ralls 2014-02-12 03:37:31 UTC 
sys.platform == 'darwin' is the right way to do it. Shelling out is expensive, and there's no reason to do so.
Comment 3 Allison Karlitskaya (desrt) 2015-01-03 20:33:32 UTC 
Bug 742267 obsoletes this complaint.

*** This bug has been marked as a duplicate of bug 742267 ***