After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 724182 - gst-rtsp-server: stop thread if media is shared
gst-rtsp-server: stop thread if media is shared
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-rtsp-server
git master
Other Linux
: Normal normal
: 1.2.3
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-02-11 22:18 UTC by Aleix Conchillo Flaqué
Modified: 2014-02-25 22:28 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
stop thread if media is already prepared (988 bytes, patch)
2014-02-11 22:23 UTC, Aleix Conchillo Flaqué 		none Details | Review

Description Aleix Conchillo Flaqué 2014-02-11 22:18:06 UTC 
Before preparing the media, a thread is obtained from the thread pool. This thread is given to gst_rtsp_media_prepare() and used there. However, if the media is already preapred (e.g. media is shared) the thread is not used, so a leak occurs.
Comment 1 Aleix Conchillo Flaqué 2014-02-11 22:23:28 UTC 
Created attachment 268855 [details] [review]
stop thread if media is already prepared
Comment 2 Wim Taymans 2014-02-18 10:06:41 UTC 
commit 0bd687f2107f613d33060484fa86159c288d4a1e
Author: Aleix Conchillo Flaqué <aleix@oblong.com>
Date:   Tue Feb 11 14:20:39 2014 -0800

    media: stop thread if media is already prepared
    
    in gst_rtsp_media_prepare() the thread is not used if media is already
    prepared (e.g. media shared) so we want to stop the thread. otherwise, a
    leak occurs.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=724182