After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 724178 - Don't close chats when pressing esc
Don't close chats when pressing esc
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: telepathy
unspecified
Other Linux
: Normal normal
: ---
Assigned To: GNOME Shell Telepathy maintainer(s)
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2014-02-11 21:20 UTC by Giovanni Campagna
Modified: 2014-03-12 18:34 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
MessageTray: don't destroy notifications when the user presses ESC (2.23 KB, patch)
2014-02-26 13:46 UTC, Giovanni Campagna 		committed Details | Review

Description Giovanni Campagna 2014-02-11 21:20:20 UTC 
If I press esc while a toaster telepathy notification is focused, it should hide, not destroy, because if destroyed, the channel is closed and there is no way to get it back.
Comment 1 drago01 2014-02-12 19:49:41 UTC 
We have talked about this at the end of the 3.10 cycle but ended up not doing it .. don't remember why but it makes sense imo.
Comment 2 Giovanni Campagna 2014-02-12 19:52:15 UTC 
(In reply to comment #1)
> We have talked about this at the end of the 3.10 cycle but ended up not doing
> it .. don't remember why but it makes sense imo.

I guess simplicity of implementation - I remember talking about the close button, never about esc...

(Then again, I support close-as-hide for resident sources, at least in the toaster)
Comment 3 Giovanni Campagna 2014-02-26 13:46:27 UTC 
Created attachment 270384 [details] [review]
MessageTray: don't destroy notifications when the user presses ESC

Doing so is inconsistent with the behavior in the summary, and
is quite annoying when dealing with chats (because there is no way
to unfocus a chat notification with the keyboard only)
Comment 4 drago01 2014-03-12 18:27:50 UTC 
Review of attachment 270384 [details] [review]:

OK I though about saying just do it for chats but that would be rather messy and inconsistent (and the only notifications where user interact with the keyboard are mostly chats anyway).

Code looks good.
Comment 5 Giovanni Campagna 2014-03-12 18:33:55 UTC 
Attachment 270384 [details] pushed as 057a026 - MessageTray: don't destroy notifications when the user presses ESC