Created attachment 268824 [details] [review]
disconnect signals sooner on tabs

Created attachment 268846 [details] [review]
disconnect signals sooner on tabs

Review of attachment 268846 [details] [review]:

pushed

I am leaving the bug open since as far as I understood you have some more patches in the pipeline

just as a reminder:

 - one of the things to fix is to not make the group rows selectable

Created attachment 268889 [details] [review]
 documents-panel: make GroupRow unselectable

encountered remaining bug :

- when making a new window from a tab ( contextual menu on tab,
  move to a new window, no focus on the text view at first.

- when hovering a row, close button appear and the row height change.

- on some configuration, the first row flicker when hovering it.

Created attachment 268902 [details] [review]
focus on text view when creating new window from tab

probably not directly related but it is here.

Review of attachment 268889 [details] [review]:

Committed, though I wonder if the group row should also not prelight since they are not selectable

Review of attachment 268902 [details] [review]:

committed. thanks

For the flickering bug, it is confirmed that it's a gtk+ bug :

https://bugzilla.gnome.org/show_bug.cgi?id=698730

Created attachment 269199 [details] [review]
 documents-panel: changes for style

Created attachment 269200 [details] [review]
adwaita : gedit: documents-panel style changes

Review of attachment 269199 [details] [review]:

thanks!

Review of attachment 269200 [details] [review]:

thanks!