After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 724123 - pocket: Bump required gnome-online-accounts version
pocket: Bump required gnome-online-accounts version
Status: RESOLVED FIXED
Product: grilo
Classification: Other
Component: plugins
unspecified
Other All
: Normal normal
: ---
Assigned To: grilo-maint
grilo-maint
Depends on:
Blocks:
 
 
Reported: 2014-02-11 15:18 UTC by Bastien Nocera
Modified: 2014-02-13 13:13 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
pocket: Bump required gnome-online-accounts version (975 bytes, patch)
2014-02-11 15:18 UTC, Bastien Nocera 		none Details | Review
pocket: gnome-online-accounts >= 3.11.4 required (2.89 KB, patch)
2014-02-13 12:50 UTC, Juan A. Suarez Romero 		committed Details | Review

Description Bastien Nocera 2014-02-11 15:18:51 UTC 
.
Comment 1 Bastien Nocera 2014-02-11 15:18:54 UTC 
Created attachment 268798 [details] [review]
pocket: Bump required gnome-online-accounts version

Which adds the goa_account_get_read_later_disabled()
function used by the Pocket source.
Comment 2 Juan A. Suarez Romero 2014-02-13 12:50:06 UTC 
Created attachment 269001 [details] [review]
pocket: gnome-online-accounts >= 3.11.4 required

Which adds the goa_account_get_read_later_disabled()
function used by the Pocket source.
Comment 3 Juan A. Suarez Romero 2014-02-13 12:54:15 UTC 
As gnome-online-accounts  3.11.4 is pretty new, and other plugins also depend on gnome-online-accounts, I've slightly changed the patch so it only requires this new version for Pocket. Thus, if you have an older version, pocket won't be built, but the others will.
Comment 4 Bastien Nocera 2014-02-13 12:59:04 UTC 
Review of attachment 269001 [details] [review]:

That looks fine.
Comment 5 Juan A. Suarez Romero 2014-02-13 13:12:54 UTC 
commit f7249b684782dc164774b285726666570c3ac104
Author: Juan A. Suarez Romero <jasuarez@igalia.com>
Date:   Thu Feb 13 12:35:42 2014 +0000

    pocket: gnome-online-accounts >= 3.11.4 required
    
    Which adds the goa_account_get_read_later_disabled()
    function used by the Pocket source.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=724123

 configure.ac | 12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)