After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 724116 - get rid of libcelt
get rid of libcelt
Product: jhbuild
Classification: Infrastructure
Component: module sets
Other All
: Normal normal
: ---
Assigned To: Jhbuild maintainers
Jhbuild QA
Depends on:
Reported: 2014-02-11 14:38 UTC by Allison Karlitskaya (desrt)
Modified: 2014-02-11 16:16 UTC
See Also:
GNOME target: ---
GNOME version: ---

apps: clean up spice, drop celt, use opus (3.85 KB, patch)
2014-02-11 14:40 UTC, Allison Karlitskaya (desrt)
committed Details | Review

Description Allison Karlitskaya (desrt) 2014-02-11 14:38:29 UTC
libcelt is unmaintained and it won't build on FreeBSD.  Let's get rid of
this mess.
Comment 1 Allison Karlitskaya (desrt) 2014-02-11 14:40:54 UTC
Created attachment 268792 [details] [review]
apps: clean up spice, drop celt, use opus

Update to the latest release of spice-gtk, which (after much
anticipation) supports opus instead of the long-unmaintained celt051.

Drop spice-protocol as a dependency of spice-gtk since it is now rolled
into the tarball upstream (via gitsubmodules).

Drop spice-server as well because nothing in the entire moduleset
actually uses it.

Add a sysdep for opus.
Comment 2 Javier Jardón (IRC: jjardon) 2014-02-11 15:43:48 UTC
Review of attachment 268792 [details] [review]:

Sure, thanks for working on this, after the little comment please commit!

::: modulesets/gnome-sysdeps-3.12.modules
@@ +829,3 @@
+  <systemmodule id="opus">
+    <pkg-config>opus</pkg-config>
+    <branch repo="system" version="0.28"/>

change this to version 1.0 (available in debian stable, ubuntu quantal, fedora 19)
Comment 3 Allison Karlitskaya (desrt) 2014-02-11 15:44:49 UTC
The problem is that pkg-config --version reports 0.28 regardless of the actual version of the installed package...
Comment 4 Javier Jardón (IRC: jjardon) 2014-02-11 15:49:30 UTC
pkg-config --version output the versionversion of pkg-config itself.
pkg-config --modversion is what you want to use :)
Comment 5 Allison Karlitskaya (desrt) 2014-02-11 16:13:11 UTC
Hilarious.  Thanks :)
Comment 6 Allison Karlitskaya (desrt) 2014-02-11 16:16:56 UTC
Attachment 268792 [details] pushed as d4446a8 - apps: clean up spice, drop celt, use opus