After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 724099 - Various style improvements
Various style improvements
Status: RESOLVED FIXED
Product: gtk-doc
Classification: Platform
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gtk-doc maintainers
gtk-doc maintainers
Depends on:
Blocks:
 
 
Reported: 2014-02-11 05:13 UTC by William Jon McCann
Modified: 2014-02-12 15:15 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Use unicode line art instead of ascii art for hierarchy (1.84 KB, patch)
2014-02-11 05:13 UTC, William Jon McCann
committed Details | Review
style: lighten the navigation header background color (1.02 KB, patch)
2014-02-11 05:13 UTC, William Jon McCann
committed Details | Review
Don't display titles on admonition blocks (1.67 KB, patch)
2014-02-11 05:13 UTC, William Jon McCann
none Details | Review
Set a max width on screen devices (753 bytes, patch)
2014-02-11 05:13 UTC, William Jon McCann
none Details | Review
Tweak the spacings in the css (841 bytes, patch)
2014-02-11 05:13 UTC, William Jon McCann
none Details | Review
Use a non-breaking space in function types (842 bytes, patch)
2014-02-11 05:13 UTC, William Jon McCann
none Details | Review
Don't display titles on admonition blocks (2.17 KB, patch)
2014-02-11 19:09 UTC, William Jon McCann
committed Details | Review
Set a max width on screen devices (753 bytes, patch)
2014-02-11 19:09 UTC, William Jon McCann
committed Details | Review
Tweak the spacings in the css (841 bytes, patch)
2014-02-11 19:09 UTC, William Jon McCann
committed Details | Review
Use a non-breaking space in function types (842 bytes, patch)
2014-02-11 19:09 UTC, William Jon McCann
committed Details | Review
Fix heading and footing padding (807 bytes, patch)
2014-02-11 19:09 UTC, William Jon McCann
committed Details | Review
Group classes with the same styles (1.39 KB, patch)
2014-02-11 19:09 UTC, William Jon McCann
committed Details | Review
Use non-breaking space between function name and () (1.16 KB, patch)
2014-02-11 19:09 UTC, William Jon McCann
committed Details | Review
Use a style class on C punctuation (1.55 KB, patch)
2014-02-11 19:09 UTC, William Jon McCann
committed Details | Review
Tone down the blackness of h4 headings (659 bytes, patch)
2014-02-11 19:09 UTC, William Jon McCann
committed Details | Review
Dim the link text in non-primary columns (986 bytes, patch)
2014-02-11 19:09 UTC, William Jon McCann
committed Details | Review
Tone down the non-primary column colors a bit more (688 bytes, patch)
2014-02-11 19:10 UTC, William Jon McCann
committed Details | Review
Dim the | separators in the navigation bar (14.26 KB, patch)
2014-02-11 19:10 UTC, William Jon McCann
committed Details | Review
Tone down the backgrounds under blocks (2.08 KB, patch)
2014-02-11 19:10 UTC, William Jon McCann
committed Details | Review

Description William Jon McCann 2014-02-11 05:13:04 UTC
Here are a few stylistic improvements to the docs display.
Comment 1 William Jon McCann 2014-02-11 05:13:06 UTC
Created attachment 268760 [details] [review]
Use unicode line art instead of ascii art for hierarchy
Comment 2 William Jon McCann 2014-02-11 05:13:08 UTC
Created attachment 268761 [details] [review]
style: lighten the navigation header background color
Comment 3 William Jon McCann 2014-02-11 05:13:11 UTC
Created attachment 268762 [details] [review]
Don't display titles on admonition blocks
Comment 4 William Jon McCann 2014-02-11 05:13:14 UTC
Created attachment 268763 [details] [review]
Set a max width on screen devices

This ensures the content does stretch too wide to read.
Comment 5 William Jon McCann 2014-02-11 05:13:17 UTC
Created attachment 268764 [details] [review]
Tweak the spacings in the css
Comment 6 William Jon McCann 2014-02-11 05:13:20 UTC
Created attachment 268765 [details] [review]
Use a non-breaking space in function types
Comment 7 William Jon McCann 2014-02-11 19:09:16 UTC
Created attachment 268825 [details] [review]
Don't display titles on admonition blocks
Comment 8 William Jon McCann 2014-02-11 19:09:34 UTC
Created attachment 268826 [details] [review]
Set a max width on screen devices

This ensures the content does stretch too wide to read.
Comment 9 William Jon McCann 2014-02-11 19:09:37 UTC
Created attachment 268827 [details] [review]
Tweak the spacings in the css
Comment 10 William Jon McCann 2014-02-11 19:09:40 UTC
Created attachment 268828 [details] [review]
Use a non-breaking space in function types
Comment 11 William Jon McCann 2014-02-11 19:09:43 UTC
Created attachment 268829 [details] [review]
Fix heading and footing padding

So that heading doesn't get covered by the navigation bar and
the footing doesn't scale with font size.
Comment 12 William Jon McCann 2014-02-11 19:09:47 UTC
Created attachment 268830 [details] [review]
Group classes with the same styles
Comment 13 William Jon McCann 2014-02-11 19:09:50 UTC
Created attachment 268831 [details] [review]
Use non-breaking space between function name and ()
Comment 14 William Jon McCann 2014-02-11 19:09:53 UTC
Created attachment 268832 [details] [review]
Use a style class on C punctuation
Comment 15 William Jon McCann 2014-02-11 19:09:56 UTC
Created attachment 268833 [details] [review]
Tone down the blackness of h4 headings

These are used for "Parameters", "Returns", etc.
Comment 16 William Jon McCann 2014-02-11 19:09:59 UTC
Created attachment 268834 [details] [review]
Dim the link text in non-primary columns

This helps the primary column stand out a bit more.
Comment 17 William Jon McCann 2014-02-11 19:10:03 UTC
Created attachment 268835 [details] [review]
Tone down the non-primary column colors a bit more
Comment 18 William Jon McCann 2014-02-11 19:10:06 UTC
Created attachment 268836 [details] [review]
Dim the | separators in the navigation bar
Comment 19 William Jon McCann 2014-02-11 19:10:09 UTC
Created attachment 268837 [details] [review]
Tone down the backgrounds under blocks

The warnings, and programlistings were a bit too in your face.
Comment 20 Stefan Sauer (gstreamer, gtkdoc dev) 2014-02-11 20:16:28 UTC
Review of attachment 268832 [details] [review]:

Can we make this darker? The gray () after a function name look weird, especially on my laptop LCD, they are hard to read. Also for pointers the '*' almost blends with the white background :/
Comment 21 William Jon McCann 2014-02-11 20:32:18 UTC
Just to ensure we're evaluating the same thing. Please test it in devhelp. I recall the last time we worked on the style we noticed a few differences in rendering engines. Once we agree on how it looks in devhelp we can probably do a separate pass to polish up the web version etc.
Comment 22 William Jon McCann 2014-02-12 15:14:24 UTC
Attachment 268760 [details] pushed as 0357af2 - Use unicode line art instead of ascii art for hierarchy
Attachment 268761 [details] pushed as 8b79c63 - style: lighten the navigation header background color
Attachment 268825 [details] pushed as c4d3f71 - Don't display titles on admonition blocks
Attachment 268826 [details] pushed as f0762e6 - Set a max width on screen devices
Attachment 268827 [details] pushed as eaf3d8d - Tweak the spacings in the css
Attachment 268828 [details] pushed as 346fb61 - Use a non-breaking space in function types
Attachment 268829 [details] pushed as 2b38155 - Fix heading and footing padding
Attachment 268830 [details] pushed as 167024b - Group classes with the same styles
Attachment 268831 [details] pushed as 62d21b8 - Use non-breaking space between function name and ()
Attachment 268832 [details] pushed as d131fe5 - Use a style class on C punctuation
Attachment 268833 [details] pushed as 273a154 - Tone down the blackness of h4 headings
Attachment 268834 [details] pushed as a8a7cea - Dim the link text in non-primary columns
Attachment 268835 [details] pushed as c6b9e1f - Tone down the non-primary column colors a bit more
Attachment 268836 [details] pushed as 1018ca5 - Dim the | separators in the navigation bar
Attachment 268837 [details] pushed as 085f86d - Tone down the backgrounds under blocks