After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 724093 - videos 3.11.4, subtitle downloader plugin not working
videos 3.11.4, subtitle downloader plugin not working
Status: RESOLVED FIXED
Product: totem
Classification: Core
Component: Subtitle Downloader plugin
3.11.x
Other Linux
: Normal normal
: ---
Assigned To: General Totem maintainer(s)
General Totem maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2014-02-11 04:05 UTC by Asif Ali Rizvan
Modified: 2014-03-24 13:24 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Asif Ali Rizvan 2014-02-11 04:05:08 UTC
I enabled the subtitle plugin, restarted videos, but when I play a video and try "Subtitle->Download Movie Subtitle" it won't do anything. Nothing!
Comment 1 Bastien Nocera 2014-02-11 10:48:36 UTC
Errors on the command-line?
Comment 2 Asif Ali Rizvan 2014-02-11 11:30:45 UTC
Traceback (most recent call last):
  • File "/usr/lib64/totem/plugins/opensubtitles/opensubtitles.py", line 508 in _show_dialog
    self._build_dialog ()
  • File "/usr/lib64/totem/plugins/opensubtitles/opensubtitles.py", line 433 in _build_dialog
    self)
ValueError: Pointer arguments are restricted to integers, capsules, and None. See: https://bugzilla.gnome.org/show_bug.cgi?id=683599

fedora 21 x86_64
Comment 3 Asif Ali Rizvan 2014-02-23 05:30:39 UTC
Could we modify this nautilus subtitle downloader python script to work with gnome-videos? thanks.

we need wget installed (yum install wget)

https://github.com/emericg/OpenSubtitlesDownload


-------
 Installation

Quick installation as a nautilus script, under GNOME 3 desktop environment:

    $ git clone https://github.com/emericg/OpenSubtitlesDownload.git
    $ mkdir -p ~/.local/share/nautilus/scripts/
    $ cp OpenSubtitlesDownload/OpenSubtitlesDownload.py ~/.local/share/nautilus/scripts/OpenSubtitlesDownload.py
    $ chmod u+x ~/.local/share/nautilus/scripts/OpenSubtitlesDownload.py 
-------
Comment 4 Bastien Nocera 2014-02-24 11:45:53 UTC
(In reply to comment #3)
> Could we modify this nautilus subtitle downloader python script to work with
> gnome-videos? thanks.

You can do whatever you want. But how does that fix bugs in Totem?

I can't reproduce the problem here, it will have to wait until I upgrade, or somebody else hits that bug and fixes it.
Comment 5 M. Niess 2014-03-13 23:04:42 UTC
I've got the exact same problem with videos 3.10.1 (in Ubuntu 14.04). Any way I can help getting this sorted out?
Comment 6 Bastien Nocera 2014-03-14 10:07:36 UTC
3.11.4 was never an actual release, can you please test with Totem from the master or gnome-3-10 branch (for M. Niess that sees that problem in GNOME 3.10), or try 3.11.90.

I'm using pygobject3-3.10.2-1.fc20.x86_64 and I don't see any of those warnings.
Comment 7 M. Niess 2014-03-16 17:49:03 UTC
Ubuntu seems to ship pygobject-3.11.91.
Comment 8 M. Niess 2014-03-23 10:21:44 UTC
@Bastien: This is marked NEEDINFO. I'm unsure on what info I can provide you with, to progress this bug.
Comment 9 Bastien Nocera 2014-03-23 13:14:04 UTC
(In reply to comment #8)
> @Bastien: This is marked NEEDINFO. I'm unsure on what info I can provide you
> with, to progress this bug.

I couldn't reproduce the bug with master and the newer PyGObject, but could with the 3.10 version with the new PyGObject.

commit 960aaa5a566d614b760c54cb86e9e445ae12109a
Author: Bastien Nocera <hadess@hadess.net>
Date:   Sun Mar 23 14:05:11 2014 +0100

    opensubtitles: Fix error with newer version of PyGObject
    
    We cannot pass an object as user_data, as pygobject stopped handling
    non-integers, non-capsules or not None as possible arguments.
    
    As we do not use Totem.plugin_load_interface()'s signal connection
    feature, pass None instead.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=724093

Will be fixed in master shortly.
Comment 10 M. Niess 2014-03-23 15:58:03 UTC
I can confirm this fixes it! Thanks!
Comment 11 Bastien Nocera 2014-03-24 13:24:38 UTC
Fixed in master for 3.12.0 as well.