After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 724013 - Don't hardcode /usr/share/sounds/sf2 path in fluiddec
Don't hardcode /usr/share/sounds/sf2 path in fluiddec
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other All
: Normal enhancement
: 1.2.4
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-02-10 10:21 UTC by LRN
Modified: 2014-02-10 11:44 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Change soundfont file search path for fluiddec (4.80 KB, patch)
2014-02-10 10:23 UTC, LRN 		none Details | Review

Description LRN 2014-02-10 10:21:05 UTC 
Currently fluiddec looks for sf2 files in /usr/share/sounds/sf2. This by itself isn't wrong (this is the place where stuff is put by distros that i know (that is, Debian)). However, this path makes no sense on W32.

To fix this i'm proposing to use glib to get system shared data dirs (glib will return multiple directories most of the time), and use that to locate sf2 files.
Comment 1 LRN 2014-02-10 10:23:00 UTC 
Created attachment 268651 [details] [review]
Change soundfont file search path for fluiddec

This works on Windows (finds .sf2 file in <mingwwroot>/share/sounds/sf2). Didn't test it anywhere else.
Comment 2 Wim Taymans 2014-02-10 11:44:03 UTC 
commit 270b57fc33301f37511200e468b7ef51fdc5e672
Author: Руслан Ижбулатов <lrn1986@gmail.com>
Date:   Mon Feb 10 08:19:52 2014 +0000

    Change soundfont file search path for fluiddec
    
    Use glib to get a list of system "share" directories, then go through that
    list, appending 'sounds/sf2/' to each directory to get a soundfont directory,
    and looking for .sf2 files there.
    
    This way fluiddec is able to load sf2 files on W32, because otherwise the
    path '/usr/share/sounds/sf2' makes no sense there.
    
    Fixes #724013