After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 724010 - mpegtsmux,tsdemux: add support for private data
mpegtsmux,tsdemux: add support for private data
Status: RESOLVED INVALID
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
1.2.2
Other Linux
: Normal enhancement
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-02-10 09:41 UTC by sebastien
Modified: 2014-02-20 15:29 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch file (5.15 KB, patch)
2014-02-10 09:41 UTC, sebastien 		none Details | Review
new version of patch. (5.05 KB, patch)
2014-02-10 16:43 UTC, sebastien 		none Details | Review
MPEGTS mux patch. (2.72 KB, patch)
2014-02-20 10:53 UTC, sebastien 		none Details | Review
MPEGTS demux patch. (1.66 KB, patch)
2014-02-20 11:01 UTC, sebastien 		none Details | Review

Description sebastien 2014-02-10 09:41:55 UTC 
Created attachment 268647 [details] [review]
patch file

This is a change request.

This modification allow to mux/demux private data.

Patch file is attached.
Comment 1 sebastien 2014-02-10 16:43:04 UTC 
Created attachment 268694 [details] [review]
new version of patch.
Comment 2 sebastien 2014-02-20 10:53:41 UTC 
Created attachment 269790 [details] [review]
MPEGTS mux patch.

split previous patch in two part :
 -> MPEGTS mux
 -> MPEGTS demux
Comment 3 sebastien 2014-02-20 11:01:20 UTC 
Created attachment 269791 [details] [review]
MPEGTS demux patch.
Comment 4 Edward Hervey 2014-02-20 11:07:20 UTC 
Doesn't apply cleanly on current master (We only accept patches on master branch).

Where does this 0x8e come from ? Private data stream_type can be anything between 0x80 and 0xff according to mpeg-ts specs.
Comment 5 sebastien 2014-02-20 12:38:38 UTC 
Sorry, I have made my patch on version 1.2.2, I will provide an another one on master.

In addition, we have to recognize the stream type "application/data" and it must be associate to an identifier in order to call tsmux_create_stream. 
Do you see an another solution ?
Comment 6 sebastien 2014-02-20 15:29:19 UTC 
Ok. I will think about a new solution.