After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 724004 - No icon on Arch Linux
No icon on Arch Linux
Status: RESOLVED FIXED
Product: baobab
Classification: Core
Component: general
3.10.x
Other Linux
: Normal normal
: ---
Assigned To: Baobab Maintainers
Baobab Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-02-10 08:41 UTC by l15842
Modified: 2014-02-14 09:45 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Windows switch list (35.98 KB, image/png)
2014-02-10 08:41 UTC, l15842
  Details
Baobab with Faenza icon theme (38.34 KB, image/png)
2014-02-11 06:55 UTC, Daniel Preston
  Details
Set an icon for the main window (860 bytes, patch)
2014-02-11 10:21 UTC, Stefano Facchini
committed Details | Review

Description l15842 2014-02-10 08:41:52 UTC
Created attachment 268642 [details]
Windows switch list

On Arch Linux baobab 3.10.1-1 comes without an icon. See the attached screenshot where you see that instead a generic icon is displayed in my Openbox window switch list.

Can't the following icon be used by default?

https://git.gnome.org/browse/baobab/plain/pixmaps/hicolor_apps_256x256_baobab.png
Comment 1 André Klapper 2014-02-10 15:08:25 UTC
Where exactly is the icon missing? In front of "thinkpad /"?
Comment 2 Daniel Preston 2014-02-10 18:40:35 UTC
@Andre

The one missing in front of "thinkpad /" is due to the icon theme.

I am talking about the one which should be in front of "Devices and Locations" of the window switch list. I am pretty sure that this one is provided by the application and not by the icon theme.
Comment 3 Matthias Clasen 2014-02-11 02:27:45 UTC
I believe the icon you're missing is drive-harddisk-system, which is a perfectly standard icon name. If anything, baobab should make sure that generic fallback is enabled, so that we can work with a drive-harddisk icon too
Comment 4 Daniel Preston 2014-02-11 06:55:42 UTC
Created attachment 268767 [details]
Baobab with Faenza icon theme
Comment 5 Daniel Preston 2014-02-11 06:56:20 UTC
@Matthias

I strongly support the fallback!

I just switched to Faenza icon theme instead of my default elementary icon theme but even there, the window list icon is missing. It cannot be icon theme related (whereas the icon in front of "thinkpad" is).

See the attachment.
Comment 6 Stefano Facchini 2014-02-11 10:21:08 UTC
Created attachment 268775 [details] [review]
Set an icon for the main window
Comment 7 Daniel Preston 2014-02-11 10:30:20 UTC
@Stefano

Thanks for your quick reaction with a patch!

But which icon is then used if the icon_name is set to baobab?

Or will baobab finally provide its own packaged icon?
Comment 8 Stefano Facchini 2014-02-11 10:46:48 UTC
The "baobab" icon is currently provided by the baobab tarball so the patch should fix the issue related to the window list.
Comment 9 Daniel Preston 2014-02-11 14:15:01 UTC
Excellent. I will report back once the fix makes its way to the Arch Linux repos!
Comment 10 Stefano Facchini 2014-02-14 09:45:35 UTC
Attachment 268775 [details] pushed as e2b4ab3 - Set an icon for the main window