After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 723994 - Cannot build gnome-control-center with clang when optimization is disabled
Cannot build gnome-control-center with clang when optimization is disabled
Product: gnome-control-center
Classification: Core
Component: Universal Access
Other FreeBSD
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on:
Reported: 2014-02-10 04:08 UTC by Ting-Wei Lan
Modified: 2014-02-11 12:04 UTC
See Also:
GNOME target: ---
GNOME version: ---

Add static to some inline functions declaration (1.40 KB, patch)
2014-02-10 04:08 UTC, Ting-Wei Lan
needs-work Details | Review
Remove useless inline functions (4.53 KB, patch)
2014-02-10 09:52 UTC, Ting-Wei Lan
accepted-commit_now Details | Review

Description Ting-Wei Lan 2014-02-10 04:08:19 UTC
Created attachment 268625 [details] [review]
Add static to some inline functions declaration

In panels/universal-access/zoom-options.c, there are 3 inline functions: set_active, get_active, set_sensitive.

These 3 functions are declared without static or extern, and only inline definition is provided. Therefore, if the compiler decides not to inline these 3 functions, I will get undefined reference when linking the executable.

These 3 functions are only used inside panels/universal-access/zoom-options.c, so I think we can solve the issue by adding static to the declaration.
Comment 1 Rui Matos 2014-02-10 09:31:50 UTC
Review of attachment 268625 [details] [review]:

To save one line length? Seriously?

Can you provide a patch that just gets rid of this non-sense instead?
Comment 2 Ting-Wei Lan 2014-02-10 09:52:34 UTC
Created attachment 268650 [details] [review]
Remove useless inline functions
Comment 3 Rui Matos 2014-02-10 09:58:06 UTC
Review of attachment 268650 [details] [review]:

Great, thanks
Comment 4 Ting-Wei Lan 2014-02-11 12:04:16 UTC
attachment 268650 [details] [review] - pushed as 1ea4b3a - universal-access: Remove useless inline functions