After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 723933 - Don't assume we can always read BYTES_PER_READ
Don't assume we can always read BYTES_PER_READ
Status: RESOLVED FIXED
Product: devhelp
Classification: Applications
Component: General
unspecified
Other All
: Normal normal
: ---
Assigned To: devhelp-maint
devhelp-maint
Depends on:
Blocks:
 
 
Reported: 2014-02-09 01:45 UTC by William Jon McCann
Modified: 2014-02-09 13:16 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Don't assume we can always read BYTES_PER_READ (2.41 KB, patch)
2014-02-09 01:45 UTC, William Jon McCann 		committed Details | Review

Description William Jon McCann 2014-02-09 01:45:43 UTC 
In GTK+ master we've added a number of unicode characters to the docs.

This makes devhelp fail to correctly read the .devhelp2 index file. This
is because it assumes reading less than the requested number of bytes
means EOF.
Comment 1 William Jon McCann 2014-02-09 01:45:44 UTC 
Created attachment 268540 [details] [review]
Don't assume we can always read BYTES_PER_READ

If the next unicode character is too wide for the buffer the
total number of bytes read will be less than BYTES_PER_READ.
Comment 2 William Jon McCann 2014-02-09 13:16:48 UTC 
Attachment 268540 [details] pushed as 5ac7850 - Don't assume we can always read BYTES_PER_READ