After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 723932 - system status geolocation crosshair icon shown even though Maps not running
system status geolocation crosshair icon shown even though Maps not running
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: system-status
3.11.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2014-02-09 01:32 UTC by Hashem Nasarat
Modified: 2014-04-05 11:58 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Screenshot of the issue (290.49 KB, image/png)
2014-02-09 01:32 UTC, Hashem Nasarat
  Details
datetime: Call geoclue's stop method when we no longer need it (1.64 KB, patch)
2014-04-02 14:56 UTC, Kalev Lember
committed Details | Review

Description Hashem Nasarat 2014-02-09 01:32:52 UTC
Created attachment 268539 [details]
Screenshot of the issue

I'm using Fedora rawhide and I just updated to GNOME 3.11.5.
The crosshair icon for geolocation is always in the system status menu and I don't have any geolocation things running.
Comment 1 Giovanni Campagna 2014-02-24 16:27:57 UTC
Can you still reproduce this on 3.11.90? Are you running geoclue2 3.11.90 too?
Comment 2 Hashem Nasarat 2014-02-28 12:26:43 UTC
I just upated my rawhide machine yeterday, and I am still seeing this issue: The icon is always in the top bar, and if I expand the system status menu it says "Location Off", and clicking "Turn On" closes the menu, but doesn't discernibly change anything.

I have geoclue version 0.12.99.5.fc21, geoclue2 2.1.2-2.fc1 installed, and gnome-shell 3.11.90-4.fc21 installed.
I have jhbuild set up on this machine, but idk how to run geoclue2 & gnome-shell from source in a way that they can communicate.

Also, I tried removing geoclue, but then yum wanted me to also remove many other packages, so I declined.
Comment 3 maxx 2014-03-16 12:09:03 UTC
This is also happening for me with gnome-shell-3.11.91 and geoclue2-2.1.6
Comment 4 Allan Day 2014-03-17 09:11:54 UTC
Maps isn't the only thing that can use geolocation. Just to check - can you confirm that this always happens when all apps are closed? Also, it might be worth checking that automatic time zone is turned off (you can find this in the time and date settings).
Comment 5 Hashem Nasarat 2014-03-17 13:58:59 UTC
This happens when all applications are closed. I'll try later today to see what happens with automatic time zone support turned off.
Comment 6 Zeeshan Ali 2014-03-17 14:42:45 UTC
Its likely that this happens because the needed changes to 'auto tz update' hasn't made it to settings-daemon.

Kalev?
Comment 7 Kalev Lember 2014-03-17 15:03:44 UTC
Yes, it could be the the Automatic Time Zone functionality that's trying to do geolocation -- can you check if this is turned on or off in the Date & Time panel in System Settings?

The way the Automatic Time Zones are implemented right now is that gnome-settings-daemon stays connected to the geoclue service all the time, and waits for it to notify for position changes. And this keeps the geolocation crosshair up in the system status menu.
Comment 8 maxx 2014-03-17 16:46:38 UTC
Turned off Automatic Time Zone. The crosshair is still there - and it is also there even if I turn Location off from the system menu.
Comment 9 Zeeshan Ali 2014-03-21 16:44:18 UTC
(In reply to comment #8)
> Turned off Automatic Time Zone. The crosshair is still there - and it is also
> there even if I turn Location off from the system menu.

That part should now (geoclue git master) be fixed.
Comment 10 Zeeshan Ali 2014-03-31 14:56:30 UTC
The rest needs to be fixed in g-s-d and I think we should aim for 3.12.1.
Comment 11 Kalev Lember 2014-04-02 14:56:53 UTC
Created attachment 273482 [details] [review]
datetime: Call geoclue's stop method when we no longer need it

This makes sure the geolocation marker in gnome-shell's status area goes
away after turning Automatic Time Zone off.

Normally, geoclue would watch for the clients to disappear on the bus,
but since we are using a shared singleton connection to the system bus
in gnome-settings-daemon, other plugins can still keep the connection
alive after we unref the dbus connection in the datetime plugin. To let
geoclue know we no longer need it, explicitly call the DBus Stop method
when stopping geolocation.
Comment 12 Zeeshan Ali 2014-04-02 15:04:44 UTC
Review of attachment 273482 [details] [review]:

Looks good. Please keep the commit shortlog under (or at least around) 50 chars as per conventions.
Comment 13 Kalev Lember 2014-04-02 15:10:53 UTC
Attachment 273482 [details] pushed as 7ff2749 - datetime: Call geoclue's stop method when we no longer need it