After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 723909 - segfault after form with password
segfault after form with password
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: Passwords, Cookies, & Certificates
git master
Other All
: Normal critical
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
: 724770 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2014-02-08 15:52 UTC by Frederic Peters
Modified: 2014-05-07 09:13 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
embed: Fix crash with some password forms (1.10 KB, patch)
2014-04-14 11:52 UTC, Bastien Nocera 		committed Details | Review

Description Frederic Peters 2014-02-08 15:52:36 UTC 
Sometimes when a "save password?" prompt would be presented, epiphany segfaults.

Running bbb6d6a639aa1e41d97349232b5247174b809133; this is (I believe) a recent regression.

+ Trace 233145

  • #0 g_type_check_instance_cast
    at gtype.c line 4002
  • #1 form_auth_data_save_requested
    at ephy-web-view.c line 644
  • #2 ffi_call_unix64
    from /usr/lib/x86_64-linux-gnu/libffi.so.6
  • #3 ffi_call
    from /usr/lib/x86_64-linux-gnu/libffi.so.6
  • #4 g_cclosure_marshal_generic
    at gclosure.c line 1447
  • #5 g_closure_invoke
    at gclosure.c line 770
  • #6 signal_emit_unlocked_R
    at gsignal.c line 3551
  • #7 g_signal_emit_valist
    at gsignal.c line 3307
  • #8 g_signal_emit
    at gsignal.c line 3363
  • #9 ephy_web_extension_proxy_form_auth_save_requested
    at ephy-web-extension-proxy.c line 194
  • #10 web_extension_form_auth_save_requested
    at ephy-embed-shell.c line 140
  • #11 emit_signal_instance_in_idle_cb
    at gdbusconnection.c line 3738
  • #12 g_idle_dispatch
    at gmain.c line 5280
  • #13 g_main_dispatch
    at gmain.c line 3066
  • #14 g_main_context_dispatch
    at gmain.c line 3641
  • #15 g_main_context_iterate
    at gmain.c line 3712
  • #16 g_main_context_iteration
    at gmain.c line 3773
  • #17 g_application_run
    at gapplication.c line 2127
  • #18 main
    at ephy-main.c line 488 






Comment 1


Frederic Peters





          2014-02-23 21:03:36 UTC
        



*** Bug 724770 has been marked as a duplicate of this bug. ***






Comment 2


Frederic Peters





          2014-03-18 14:24:57 UTC
        



This still happens (this time I got a trace with webkit symbols installed).





+
Trace
    233358






    

  • 
#0
__GI_raise

    
                at ../nptl/sysdeps/unix/sysv/linux/raise.c
                  line
                  56

    

    • 

  • 
#1
__GI_abort

    
                at abort.c
                  line
                  89

    

    • 

  • 
#2
g_assertion_message

    • 

  • 
#3
g_assertion_message_expr

    • 

  • 
#4
form_auth_data_save_requested

    
                at ephy-web-view.c
                  line
                  684

    

    • 

  • 
#5
ffi_call_unix64

    
                from
                /usr/lib/x86_64-linux-gnu/libffi.so.6

    

    • 

  • 
#6
ffi_call

    
                from
                /usr/lib/x86_64-linux-gnu/libffi.so.6

    

    • 

  • 
#7
g_cclosure_marshal_generic

    
                at gclosure.c
                  line
                  1445

    

    • 

  • 
#8
g_closure_invoke

    
                at gclosure.c
                  line
                  768

    

    • 

  • 
#9
signal_emit_unlocked_R

    
                at gsignal.c
                  line
                  3551

    

    • 

  • 
#10
g_signal_emit_valist

    
                at gsignal.c
                  line
                  3307

    

    • 

  • 
#11
g_signal_emit

    
                at gsignal.c
                  line
                  3363

    

    • 

  • 
#12
ephy_web_extension_proxy_form_auth_save_requested

    
                at ephy-web-extension-proxy.c
                  line
                  195

    

    • 

  • 
#13
web_extension_form_auth_save_requested

    
                at ephy-embed-shell.c
                  line
                  148

    

    • 

  • 
#14
emit_signal_instance_in_idle_cb

    
                at gdbusconnection.c
                  line
                  3750

    

    • 

  • 
#15
g_idle_dispatch

    
                at gmain.c
                  line
                  5319

    

    • 

  • 
#16
g_main_dispatch

    
                at gmain.c
                  line
                  3064

    

    • 

  • 
#17
g_main_context_dispatch

    
                at gmain.c
                  line
                  3663

    

    • 

  • 
#18
g_main_context_iterate

    
                at gmain.c
                  line
                  3734

    

    • 

  • 
#19
g_main_context_iteration

    
                at gmain.c
                  line
                  3795

    

    • 

  • 
#20
g_application_run

    
                at gapplication.c
                  line
                  2114

    

    • 

  • 
#21
main

    
                at ephy-main.c
                  line
                  488

    

    • 













Comment 3


Bastien Nocera





          2014-04-14 11:47:42 UTC
        



I can reproduce this easily by trying to login to https://www.openstreetmap.org/login?cookie_test=true&referer=%2F using OpenID.

The assertion is:
ERROR:ephy-web-view.c:684:form_auth_data_save_requested: assertion failed: (webkit_web_view_get_page_id (WEBKIT_WEB_VIEW (web_view)) == page_id)






Comment 4


Bastien Nocera





          2014-04-14 11:52:40 UTC
        



Created attachment 274259 [details] [review]
embed: Fix crash with some password forms

31bc1fe6 transformed a simple escape hatch of a comparison into an
assertion. But that assertion keeps getting triggered, so it's clearly
the wrong option for now.






Comment 5


Bastien Nocera





          2014-04-14 11:53:48 UTC
        



FWIW, I'm using the single process model, not the default multi process option because of memory usage.

Fred, do you use the default process model, or the single one to reproduce this bug?






Comment 6


Carlos Garcia Campos





          2014-04-14 11:58:52 UTC
        



Bastien, you are right, that assert only makes sense in multiprocess mode, but even in that case it won't be correct once we support other multi process models, or if we introduce the maximum number of processes.






Comment 7


Carlos Garcia Campos





          2014-04-14 11:59:17 UTC
        



Comment on attachment 274259 [details] [review]
embed: Fix crash with some password forms

Thanks






Comment 8


Bastien Nocera





          2014-04-14 13:12:48 UTC
        



Attachment 274259 [details] pushed as 0c050be - embed: Fix crash with some password forms






Comment 9


Debarshi Ray





          2014-05-07 09:13:05 UTC
        



(In reply to comment #5)

Reading through the comments, I think I suffer from this bug too even if I have never actually tried to get a backtrace because it always happens when I am in a hurry and restarting the browser usually lets me log in.

> FWIW, I'm using the single process model, not the default multi process option
> because of memory usage.
> 
> Fred, do you use the default process model, or the single one to reproduce this
> bug?

I have process-model set to one-secondary-process-per-web-view.

I will test the patch and see if there is an improvement.