GNOME Bugzilla – Bug 723907
Thumbnails film strip looks crude and is unnecessary
Last modified: 2014-02-08 23:45:19 UTC
+++ This bug was initially created as a clone of Bug #723832 +++ We know it's a video - we don't need the film strip. Also, they don't look very good.
Created attachment 268502 [details] [review] Add film strip in nautilus rather than in thumbnailer This allows front-ends such as Totem to use the generated thumbnails without the film strip.
Review of attachment 268502 [details] [review]: Looks mostly good, thanks. ::: libnautilus-private/nautilus-file.c @@ +4077,3 @@ + + for (i = 0; video_mime_types[i] != NULL; i++) { + Should we use g_content_type_is_a() here or is the list in nautilus-video-mime-types.h already extensive enough?
(In reply to comment #2) > Should we use g_content_type_is_a() here or is the list in > nautilus-video-mime-types.h already extensive enough? Pretty extensive already, but we can use is_a() as well. OK to commit afterwards?
Yeah, feel free to push after changing that to g_content_type_is_a(). Thanks!
Created attachment 268537 [details] [review] Add film strip in nautilus rather than in thumbnailer This allows front-ends such as Totem to use the generated thumbnails without the film strip.
Attachment 268537 [details] pushed as 94d2087 - Add film strip in nautilus rather than in thumbnailer