After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 723847 - Non-void function should return a value
Non-void function should return a value
Status: RESOLVED FIXED
Product: libmediaart
Classification: Other
Component: Cache
unspecified
Other FreeBSD
: Normal normal
: ---
Assigned To: libmediaart maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2014-02-07 12:35 UTC by Ting-Wei Lan
Modified: 2014-02-07 16:06 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix "Non-void function should return a value" (456 bytes, patch)
2014-02-07 12:35 UTC, Ting-Wei Lan 		committed Details | Review

Description Ting-Wei Lan 2014-02-07 12:35:26 UTC 
Created attachment 268400 [details] [review]
Fix "Non-void function should return a value"

In libmediaart/cache.c, function media_art_remove uses g_return_if_fail, which
should be replaced by g_return_val_if_fail.
Comment 1 Martyn Russell 2014-02-07 16:06:05 UTC 
Comment on attachment 268400 [details] [review]
Fix "Non-void function should return a value"

Thank you for the patch! :)
Comment 2 Martyn Russell 2014-02-07 16:06:15 UTC 
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.