GNOME Bugzilla – Bug 723829
OSD playback controls don't look great
Last modified: 2014-05-05 12:29:00 UTC
Created attachment 268390 [details] screenshot & mockup The new floating OSD playback toolbar in Videos doesn't look great. Most obvious issues: * Insensitive buttons are far too prominent and look a bit broken. * Icon buttons aren't always square. * The slider looks awkward - the trough has a visual complexity that doesn't really work in this context. * Buttons don't always have a raised look. I've attached an image with a screenshot and a mockup for how it could look. Changes include: * Darker & more transparent background colour for insensitive buttons. * Darker button borders. * Icons in buttons are lighter. * Icon buttons are always square (even when joined) - 34px by 34px. * Slider trough has a single flat colour. * Slider trough border is much darker. * All buttons have a raised appearance.
(In reply to comment #0) <snip> > * Icon buttons are always square (even when joined) - 34px by 34px. Note that for the play/pause button, we just adding left/right margins right now. It would be great if there was a class for it rather than hardcoding spacing in totem's sources.
Created attachment 268403 [details] [review] osd: flatter troughs for OSD
Created attachment 268405 [details] [review] osd: flatter troughs for OSD
Created attachment 268406 [details] [review] osd: fix insensitive buttons
Created attachment 268410 [details] screenshot: before
Created attachment 268411 [details] screenshot: after
Looks great! It would be good to find out why some of the buttons don't have a raised appearance (maybe that's an issue for another bug though).
(In reply to comment #7) > Looks great! > > It would be good to find out why some of the buttons don't have a raised > appearance (maybe that's an issue for another bug though). You mean the volume and the 'more' buttons on the right of the floating bar? Or the fact that the seek buttons really don't need to be in the view, rather than being insensitive?
One thing missing is styling of the 'buffered' trough. Not closing yet. Attachment 268405 [details] pushed as 5c72b4f - osd: flatter troughs for OSD Attachment 268406 [details] pushed as 0562d04 - osd: fix insensitive buttons
(In reply to comment #8) > (In reply to comment #7) > > Looks great! > > > > It would be good to find out why some of the buttons don't have a raised > > appearance (maybe that's an issue for another bug though). > > You mean the volume and the 'more' buttons on the right of the floating bar? Yes. It looks odd having them flat; they don't look sensitive.
Created attachment 268654 [details] screenshot - pressed button Another issue that I just noticed - button borders get brighter when pressed. The play button also loses its right-hand border.
A lot of these issues were fixed for 3.12. Let's tackle any remaining issues with individual bug reports.