After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 723819 - glade-design-view.c:671]: (style) Same expression on both sides of '<'
glade-design-view.c:671]: (style) Same expression on both sides of '<'
Status: RESOLVED FIXED
Product: glade
Classification: Applications
Component: user interface
git master
Other Linux
: Normal normal
: ---
Assigned To: Glade 3 Maintainers
Glade 3 Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-02-07 08:21 UTC by dcb
Modified: 2014-03-14 14:14 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Correct bounds checking for design view highlight (1.10 KB, patch)
2014-03-13 12:31 UTC, Chris Johns (ter0)
committed Details | Review

Description dcb 2014-02-07 08:21:11 UTC
Source code is

  gboolean highlight = !(x < 0 || y < y);

Maybe

  gboolean highlight = !(x < 0 || y < 0);

was intended.
Comment 1 Chris Johns (ter0) 2014-03-13 12:31:11 UTC
Created attachment 271704 [details] [review]
Correct bounds checking for design view highlight

I agree. As noted in the patch, it doesn't actually affect the behaviour, but would still be preferable.
Comment 2 Juan Pablo Ugarte 2014-03-14 14:14:17 UTC
Hi guys, thanks for reporting and the patch!
pushed to master!