After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 723813 - Fix the build of tools on Windows/MSVC
Fix the build of tools on Windows/MSVC
Status: RESOLVED FIXED
Product: json-glib
Classification: Core
Component: Core
git master
Other Windows
: Normal normal
: ---
Assigned To: json-glib-maint
json-glib-maint
Depends on:
Blocks:
 
 
Reported: 2014-02-07 03:44 UTC by Fan, Chun-wei
Modified: 2014-02-07 11:02 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix the build of tools on Windows when we don't have unistd.h (1.83 KB, patch)
2014-02-07 03:44 UTC, Fan, Chun-wei 		committed Details | Review

Description Fan, Chun-wei 2014-02-07 03:44:16 UTC 
Created attachment 268371 [details] [review]
Fix the build of tools on Windows when we don't have unistd.h

Hi,

There are two new utility programs that were added for JSON-GLib, which unfortunately did not build on Windows/MSVC due to an unconditional include of unistd.h, which is unfortunately not universally available.  The patch attached here is meant to fix the build of those tools under such situations, and the definition of STDOUT_FILENO is taken from the MinGW unistd.h header, to be used when unistd.h is not available on Windows.

With blessings, thank you!
Comment 1 Emmanuele Bassi (:ebassi) 2014-02-07 09:33:09 UTC 
Review of attachment 268371 [details] [review]:

looks good.
Comment 2 Fan, Chun-wei 2014-02-07 11:02:24 UTC 
Review of attachment 268371 [details] [review]:

Hi Emmanuele,

Thanks for the reviews.  The patch was pushed as d97be101.

With blessings, thank you!