After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 723805 - Xcode 5 / iOS: _locale_charset usage in libiconv is apparently non-public API
Xcode 5 / iOS: _locale_charset usage in libiconv is apparently non-public API
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: packages
1.x
Other Mac OS
: Normal major
: 1.2.2
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-02-06 23:14 UTC by Mike McNamara
Modified: 2014-11-08 14:23 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
0001-ios-workaround-false-positive-with-Apple-s-private-A.patch (1.36 KB, patch)
2014-02-07 09:34 UTC, Andoni Morales
committed Details | Review

Description Mike McNamara 2014-02-06 23:14:00 UTC
This one I don't fully understand unfortunately...  Submitting to Apple's app store will fail with a non-public API error for _locale_charset which I tracked down in libiconv:

libiconv.a(localcharset.o) (for architecture armv7):
00000718 b _charset_aliases
00000000 T _locale_charset
         U _nl_langinfo
         U _strcmp
         U _strlen

I don't know if this is because Apple has its own version of libiconv you can link against in Xcode?  It doesn't seem like a non-public API -- but there it is.

This is building GStreamer 1.2.1 using the 1.2.1 version of cerbero.
Comment 1 Sebastian Dröge (slomo) 2014-02-07 08:08:37 UTC
This seems like a false positive on Apple's side... *we* ship that API, we're not using theirs.
Comment 2 Andoni Morales 2014-02-07 09:27:06 UTC
We should probably rename this symbol for iOS. It's also in libcharset.a and libintl.a
Comment 3 Andoni Morales 2014-02-07 09:34:09 UTC
Created attachment 268389 [details] [review]
0001-ios-workaround-false-positive-with-Apple-s-private-A.patch
Comment 4 Andoni Morales 2014-02-07 09:50:40 UTC
commit 88fb5669bce1405488c128c8512cac77efd338a3
Author: Andoni Morales Alastruey <ylatuya@gmail.com>
Date:   Fri Feb 7 10:30:49 2014 +0100

    ios: workaround false positive with Apple's private API
    
    locale_charset is considered private API even though where are
    providing it. The symbol is renamed to avoid conflicts
    
    https://bugzilla.gnome.org/show_bug.cgi?id=723805
Comment 5 Mike McNamara 2014-02-07 18:26:58 UTC
I can report that with this patch uploads to Apple are in fact passing.  Thanks very much.
Comment 6 Allen 2014-07-25 16:51:23 UTC
Hello, 
  Thanks for the new patch. Do you have a Gstreamer binary for iOS, built with this new patch.
Comment 7 Sebastian Dröge (slomo) 2014-07-25 22:48:48 UTC
The releases since 1.2.2 should all have this, including the latest 1.4.0 release.